Add exception information to traces #694
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update unit tests - Update C# version to 9.0
This should avoid the many `byte[]` allocations that happen periodically, and impact performance. Co-authored-by: Itay Sagui <itsagui@microsoft.com>
This PR adds the SBOM manifest to the DurableTask.AzureStorage Release NuGet package. It adds a dotnet publish step and moves the manifest generator step to come before the dotnet pack step. It also adds a .nuspec file that specifies the additional files that need to get added to the NuGet package during dotnet pack.
Co-authored-by: Itay Sagui <itsagui@microsoft.com>
…e Fabric provider (#689) * Adding an option to log structured events vis LoggerFactory in Service Fabric provider * Bumping up the dll version
This PR fixes the license in the .nuspec files from MIT to Apache 2.0.
…g to newer release pipeline (#691) * Adding SBOM to DT.AzureServiceFabric Release Nuget packages and moving to newer release pipeline * Updating license text * Updating AzureServiceFabric package generation to not include dependent binaries * Removing publish step from the pipeline for AzureServiceFabric package * Setting default platform for Service Fabric dependent binaries to x64 to get rid of build warnings. (SF binaries are x64 only)
cgillum
reviewed
Mar 17, 2022
|
Tagging @jviau for comments. |
* add multi instance query support logics * have return type as OrchestrationStatusQueryResult * remove unnecessary files copied from durable extension * made property in OrchestrationQueryResult read only * fix parameter name - make ContinuationToken nullable - throw exception if orchestrationState is null * make continuationToken null in constructor
* Purge instance history * Renamed Core/PurgeHistoryResult to Core/PurgeResult.cs to remove ambiguity * Code refactor * Minor style updates Co-authored-by: Chris Gillum <cgillum@gmail.com>
* Also updating DT.Core to v2.9.0 * Also updating DT.AzureStorage to v1.11.0
Co-authored-by: amdeel <52223332+amdeel@users.noreply.github.com>
Co-authored-by: Itay Sagui <itsagui@microsoft.com>
* fix lease balancer logic for ownership leases * exclude lease renewals from request throttling * rename force to throttle as suggested * fix missed occurrence of renaming throttle to force
* Also fixed app lease restart issue
- Fix misleading "lease lost" log message during shutdown - Make lease release serial instead of parallel for better determinism - Cleanup subscriptions during shutdown that were causing unexpected lease management operations
Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
…e behavior during completion (#736)
|
It looks like this PR is suddenly showing changes from other PRs that have already been merged, so I'm having trouble seeing what I should actually be reviewing. @bachuv are you able to update the PR to show only your changes? |
|
Yes, I will update the PR to clean up the commit history. It's currently ahead of the branch cgillum/opentelemetry which is why it's showing additional changes. I will update that branch and then merge those changes. I'll do that this week and ping you when it's ready for review. |
This was referenced Jan 18, 2023
bachuv
added a commit
that referenced
this pull request
Feb 7, 2023
|
Closing in favor of #853 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds exception information to traces when an orchestration or activity throws an exception. Two tags are added to the trace Activity:
otel.status_codeandotel.status_description. These tags are how the Activity status is set.This is the approach we are using to set the Activity's status. This is what is listed in the .NET distributed tracing docs:
Reference:
Add distributed tracing instrumentation - .NET | Microsoft Docs
Images:
