Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): tighten GHA permissions #110

Merged
merged 2 commits into from
Jan 26, 2024
Merged

fix(ci): tighten GHA permissions #110

merged 2 commits into from
Jan 26, 2024

Conversation

tallaxes
Copy link
Collaborator

Description

This tightens the permissions on GitHub Actions, prepping for expected changes to GITHUB_TOKEN. Should resolve all high Token-Permissions security code scanning alerts (https://github.com/Azure/karpenter-provider-azure/security/code-scanning?query=Token-Permissions+is%3Aopen+branch%3Amain+severity%3Ahigh)

How was this change tested?

  • To be tested in CI

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


@tallaxes tallaxes added area/security Issues or PRs related to security area/ci Issues or PRs related to ci labels Jan 25, 2024
@tallaxes tallaxes self-assigned this Jan 25, 2024
@coveralls
Copy link

coveralls commented Jan 25, 2024

Pull Request Test Coverage Report for Build 7672393261

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.626%

Totals Coverage Status
Change from base Build 7663328991: 0.0%
Covered Lines: 35605
Relevant Lines: 36471

💛 - Coveralls

Copy link
Collaborator

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with completing. Just watch the first E2E CI run to make sure the perms actually work.

I have a slightly memory of needing to request the perms at the highest level workflow, but maybe that was just to make things simple.

.github/workflows/e2e-matrix.yaml Show resolved Hide resolved
@tallaxes tallaxes merged commit 31b0dfc into main Jan 26, 2024
8 checks passed
@tallaxes tallaxes deleted the tallaxes/actions-security branch January 26, 2024 19:23
@tallaxes tallaxes mentioned this pull request Jan 26, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Issues or PRs related to ci area/security Issues or PRs related to security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants