Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing job permissions #115

Merged
merged 3 commits into from
Jan 26, 2024
Merged

fix: add missing job permissions #115

merged 3 commits into from
Jan 26, 2024

Conversation

tallaxes
Copy link
Collaborator

@tallaxes tallaxes commented Jan 26, 2024 •
edited
Loading

Description

Follow-up to #110, adding missing permissions

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

@coveralls
Copy link

coveralls commented Jan 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7673944988

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.626%
Totals Coverage Status
Change from base Build 7672482851: 0.0%
Covered Lines: 35605
Relevant Lines: 36471
💛 - Coveralls

charliedmcb
charliedmcb approved these changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the E2E workflow passing, I'm happy for this new version to go in

@tallaxes tallaxes self-assigned this Jan 26, 2024
@tallaxes tallaxes added area/e2e-test-framework Issues or PRs related to refactoring the e2e test framework area/security Issues or PRs related to security area/ci Issues or PRs related to ci labels Jan 26, 2024
@tallaxes tallaxes merged commit 7705f24 into main Jan 26, 2024
9 checks passed
@tallaxes tallaxes deleted the tallaxes/actions-security-followup branch January 26, 2024 22:40
@tallaxes tallaxes mentioned this pull request Jan 26, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliedmcb charliedmcb charliedmcb approved these changes

Assignees

@tallaxes tallaxes

Labels
area/ci Issues or PRs related to ci area/e2e-test-framework Issues or PRs related to refactoring the e2e test framework area/security Issues or PRs related to security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tallaxes @coveralls @charliedmcb