Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create resource group before creating workload identity for local dev #131

Merged
merged 6 commits into from
Feb 1, 2024

Conversation

rakechill
Copy link
Contributor

@rakechill rakechill commented Jan 31, 2024

Description
make az-all was failing at az-create-workload-msi with RESOURCE GROUP NOT FOUND. Added az-mkrg target as prereq of workload identity creation to fix this. Also updated az- mkrg to check if the resource group exists before trying to create it.

image

How was this change tested?

  • make az-all succeeded

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Copy link
Collaborator

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would break some commands. Wondering if we can just add the rg call instead.

Makefile-az.mk Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jan 31, 2024

Pull Request Test Coverage Report for Build 7748318629

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.546%

Totals Coverage Status
Change from base Build 7748148266: 0.0%
Covered Lines: 35741
Relevant Lines: 36640

💛 - Coveralls

@tallaxes tallaxes added the area/devtools Issues or PRs related to devtools label Feb 1, 2024
charliedmcb
charliedmcb previously approved these changes Feb 1, 2024
Copy link
Collaborator

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

charliedmcb
charliedmcb previously approved these changes Feb 1, 2024
Copy link
Collaborator

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no output is fine with me, but I would generally personally prefer make commands to output what commands they are using.

Makefile-az.mk Show resolved Hide resolved
Copy link
Collaborator

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Would like a screenshot of what running the command outputs added to the PR description

@rakechill rakechill merged commit bd700b6 into main Feb 1, 2024
9 checks passed
@rakechill rakechill deleted the rakechill/fix-makefile branch February 1, 2024 22:28
@rakechill rakechill mentioned this pull request Feb 2, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues or PRs related to devtools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants