-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: create resource group before creating workload identity for local dev #131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would break some commands. Wondering if we can just add the rg call instead.
Pull Request Test Coverage Report for Build 7748318629
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no output is fine with me, but I would generally personally prefer make commands to output what commands they are using.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
Would like a screenshot of what running the command outputs added to the PR description
Description
make az-all
was failing ataz-create-workload-msi
with RESOURCE GROUP NOT FOUND. Addedaz-mkrg
target as prereq of workload identity creation to fix this. Also updatedaz- mkrg
to check if the resource group exists before trying to create it.How was this change tested?
make az-all
succeededDoes this change impact docs?