Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: az-mkrg fix #134

Merged
merged 1 commit into from
Feb 2, 2024
Merged

chore: az-mkrg fix #134

merged 1 commit into from
Feb 2, 2024

Conversation

rakechill
Copy link
Contributor

@rakechill rakechill commented Feb 2, 2024

Description
Follow-up to #131. Currently the e2e test suite + local dev via make az-all is blocked by this. The if condition was always evaluating as true, because non-empty strings in bash are truthy.

How was this change tested?

  • make az-mkrg, e2e suite (passed, except for utilization, not due to this issue)

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Copy link
Contributor Author

@rakechill rakechill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7751204900

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.546%

Totals Coverage Status
Change from base Build 7748470702: 0.0%
Covered Lines: 35741
Relevant Lines: 36640

💛 - Coveralls

Copy link
Collaborator

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like there is probably something we could do more elegant than grep, but this works :)

@rakechill rakechill merged commit 8687d3e into main Feb 2, 2024
15 of 16 checks passed
@rakechill rakechill deleted the rakechill/az-mkrg branch February 2, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants