Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add release scripts #147

Merged
merged 31 commits into from
Apr 12, 2024
Merged

feat: add release scripts #147

merged 31 commits into from
Apr 12, 2024

Conversation

tallaxes
Copy link
Collaborator

@tallaxes tallaxes commented Feb 12, 2024

Description

Add release and snapshot scripts, ksnap.azurecr.io ACR for snapshots

  • All releases (including snapshots) generate images for self-hosted and NAP (extra -aks in the tag), and Helm charts (referencing corresponding self-hosted images). Helm charts are packaged published to ACR as OCI artifacts.
  • Snapshot releases can be generated with make snapshot, use commit hash as tag. Shapshot releases go to ksnap.azurecr.io, and are retained for 30 days. (See bicep template for ksnap.)
  • Stable releases can be generated with make release, expected to be published to ACR onboarded to MCR. Stable releases have images locked after publishing (--write-enabled false --delete-enabled false).
  • The corresponding feat: add Helm-based install process #148 adds and documents the process for consuming these stable or snapshot releases, deploying Karpenter via Helm charts
  • Base images changed to mcr.microsoft.com/cbl-mariner/distroless/minimal:2.0-nonroot

How was this change tested?

  • make snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


@tallaxes tallaxes added area/artifacts Issues or PRs related to the hosting of release artifacts area/release Issues or PRs related to releasing labels Feb 12, 2024
@tallaxes tallaxes self-assigned this Feb 12, 2024
@coveralls
Copy link

coveralls commented Feb 12, 2024

Pull Request Test Coverage Report for Build 8654721864

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.761%

Totals Coverage Status
Change from base Build 8653139509: 0.0%
Covered Lines: 35672
Relevant Lines: 36489

💛 - Coveralls

Copy link
Collaborator

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looking good, but have a few nits/questions.

hack/release/common.sh Show resolved Hide resolved
hack/release/common.sh Outdated Show resolved Hide resolved
hack/release/common.sh Outdated Show resolved Hide resolved
hack/release/common.sh Outdated Show resolved Hide resolved
charts/karpenter-crd/Chart.yaml Outdated Show resolved Hide resolved
charts/karpenter/Chart.yaml Outdated Show resolved Hide resolved
charts/karpenter/values.yaml Outdated Show resolved Hide resolved
hack/infra/ksnap-acr.bicep Outdated Show resolved Hide resolved
Copy link
Collaborator

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the release process for creating a snapshot was generall smooth. I do have some suggestions noted.

Additionally, the karpenter pod I created with the current commit snapshot, and the helm based install process PR did result in a CrashLoopBackOff which I will look into further:
https://github.com/Azure/karpenter-provider-azure/pull/148/files

image

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
hack/release/common.sh Outdated Show resolved Hide resolved
hack/release/common.sh Outdated Show resolved Hide resolved
hack/release/release.sh Outdated Show resolved Hide resolved
hack/release/common.sh Outdated Show resolved Hide resolved
hack/release/common.sh Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
hack/release/common.sh Outdated Show resolved Hide resolved
hack/release/common.sh Outdated Show resolved Hide resolved
Co-authored-by: Ukri Niemimuukko <ukri.niemimuukko@intel.com>
Copy link
Collaborator

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

hack/release/common.sh Show resolved Hide resolved
hack/release/common.sh Show resolved Hide resolved
hack/release/common.sh Outdated Show resolved Hide resolved
hack/release/common.sh Outdated Show resolved Hide resolved
@tallaxes tallaxes added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 11, 2024
Copy link
Collaborator

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tallaxes tallaxes merged commit 07f783e into main Apr 12, 2024
12 checks passed
@tallaxes tallaxes deleted the tallaxes/release branch April 12, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts Issues or PRs related to the hosting of release artifacts area/release Issues or PRs related to releasing size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants