-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add release scripts #147
Conversation
Pull Request Test Coverage Report for Build 8654721864Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looking good, but have a few nits/questions.
(to be updated to latest released with the next release)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the release process for creating a snapshot was generall smooth. I do have some suggestions noted.
Additionally, the karpenter pod I created with the current commit snapshot, and the helm based install process PR did result in a CrashLoopBackOff
which I will look into further:
https://github.com/Azure/karpenter-provider-azure/pull/148/files
Co-authored-by: Ukri Niemimuukko <ukri.niemimuukko@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Description
Add
release
andsnapshot
scripts,ksnap.azurecr.io
ACR for snapshots-aks
in the tag), and Helm charts (referencing corresponding self-hosted images). Helm charts are packaged published to ACR as OCI artifacts.make snapshot
, use commit hash as tag. Shapshot releases go toksnap.azurecr.io
, and are retained for 30 days. (See bicep template for ksnap.)make release
, expected to be published to ACR onboarded to MCR. Stable releases have images locked after publishing (--write-enabled false --delete-enabled false
).mcr.microsoft.com/cbl-mariner/distroless/minimal:2.0-nonroot
How was this change tested?
make snapshot
Does this change impact docs?
Release Note