Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Helm-based install process #148

Merged
merged 35 commits into from
Apr 15, 2024
Merged

feat: add Helm-based install process #148

merged 35 commits into from
Apr 15, 2024

Conversation

tallaxes
Copy link
Collaborator

@tallaxes tallaxes commented Feb 12, 2024

Description

Add and document the procedure for creating a cluster and installing Karpenter using published Helm charts.

  • Add configure-values.sh script, which interrogates the cluster and generates karpenter-values.yaml based on karpenter-values-template.yaml. These values are used when installing Karpenter using Helm chart. Skaffold configuration is shifted to use this file as well.
  • Add create-cluster.sh script which can be used for creating clusters compatible with Kaprenter provider
  • Update readme with the procedure of creating cluster and installing Karpenter using published Helm chart and image

How was this change tested?

  • make az-mkaks-user and make az-helm-install-snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


@tallaxes tallaxes added area/artifacts Issues or PRs related to the hosting of release artifacts area/documentation Issues or PRs related to documentation area/release Issues or PRs related to releasing labels Feb 12, 2024
@tallaxes tallaxes self-assigned this Feb 12, 2024
@coveralls
Copy link

coveralls commented Feb 12, 2024

Pull Request Test Coverage Report for Build 8678237484

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.006%) to 97.725%

Files with Coverage Reduction New Missed Lines %
pkg/operator/options/options_validation.go 4 91.84%
Totals Coverage Status
Change from base Build 8669955433: -0.006%
Covered Lines: 35658
Relevant Lines: 36488

💛 - Coveralls

@tallaxes tallaxes mentioned this pull request Feb 12, 2024
3 tasks
Makefile-az.mk Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't been able to test it yet, but overall I'm liking these changes.

I do think we should hard switch over to just workload identity with this change, which I can help with.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
Makefile-az.mk Outdated Show resolved Hide resolved
@tallaxes tallaxes added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 11, 2024
charliedmcb
charliedmcb previously approved these changes Apr 12, 2024
Copy link
Collaborator

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments/recommendations, but lgtm

hack/deploy/configure-values.sh Outdated Show resolved Hide resolved
Makefile-az.mk Show resolved Hide resolved
README.md Show resolved Hide resolved
@tallaxes tallaxes merged commit e4430db into main Apr 15, 2024
10 of 11 checks passed
@tallaxes tallaxes deleted the tallaxes/helm-install branch April 15, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts Issues or PRs related to the hosting of release artifacts area/documentation Issues or PRs related to documentation area/release Issues or PRs related to releasing size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants