test(make): add taint node make command #234
Conversation
Pull Request Test Coverage Report for Build 8474483294Details
💛 - Coveralls |
| @@ -232,6 +232,9 @@ az-rmnodeclaims-fin: ## Remove Karpenter finalizer from all nodeclaims (use with | |||
| az-rmnodeclaims: ## kubectl delete all nodeclaims; don't wait for finalizers (use with care!) | |||
| kubectl delete --wait=false nodeclaims --all | |||
|
|
|||
| az-taintnodes: ## Run e2etests | |||
| kubectl taint nodes CriticalAddonsOnly=true:NoSchedule --all --overwrite | |||
There was a problem hiding this comment.
Do you have use cases where this is not constrained to system nodepool? If not - should we target it explicitly with selector?
There was a problem hiding this comment.
I use this sometiems when running perf test, but not all of the nodes have scaled down I just want to launch a bunch of small instances to test something.
So tainting all nodes is useful
There was a problem hiding this comment.
maybe tainting by label could be a second command?
There was a problem hiding this comment.
That's a fair idea. I've been running it right after cluster creation. However, it would be helpful to ensure it only targets system nodepool. I'll look at doing that.
There was a problem hiding this comment.
Will need a follow up PR though as I already completed
| @@ -232,6 +232,9 @@ az-rmnodeclaims-fin: ## Remove Karpenter finalizer from all nodeclaims (use with | |||
| az-rmnodeclaims: ## kubectl delete all nodeclaims; don't wait for finalizers (use with care!) | |||
| kubectl delete --wait=false nodeclaims --all | |||
|
|
|||
| az-taintnodes: ## Run e2etests | |||
There was a problem hiding this comment.
Thx for the catch. Got a little eager on the completion. Another reason for a follow up
Fixes #
Description
I've found I've been wanting this make command myself, so adding one to the file.
How was this change tested?
Nothing additional
*
Does this change impact docs?
Release Note