Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(make): minor follow up on taint make command #235

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

charliedmcb
Copy link
Collaborator

Fixes #

Description
@tallaxes noticed a few solid changes to make to the command after completion, so addressing them here:

How was this change tested?
Ran this on a newly created cluster and it tainted the nodes
*

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

NONE

@charliedmcb charliedmcb marked this pull request as ready for review March 28, 2024 23:11
tallaxes
tallaxes previously approved these changes Mar 28, 2024
Copy link
Collaborator

@tallaxes tallaxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (could consider having target name mention system nodes, but not critical)

@coveralls
Copy link

coveralls commented Mar 28, 2024

Pull Request Test Coverage Report for Build 8486173650

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.726%

Totals Coverage Status
Change from base Build 8476439465: 0.0%
Covered Lines: 35631
Relevant Lines: 36460

💛 - Coveralls

@charliedmcb
Copy link
Collaborator Author

LGTM (could consider having target name mention system nodes, but not critical)

Updated. I think it makes sense to more specifically mention system.

@charliedmcb charliedmcb merged commit 7759666 into main Mar 29, 2024
9 checks passed
@charliedmcb charliedmcb deleted the charliedmcb/minorFollowUpOnTaintMakeCommand branch March 29, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants