chore: using lo.FromPtr is safer than directly accessing the pointer #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nodeClass.Spec.OSDiskSizeGB dereference actually crashes when being called from the Azure cloudprovider GetInstanceTypes if the nodepool is nil. Signed-off-by: Ukri Niemimuukko <ukri.niemimuukko@intel.com>
tallaxes
approved these changes
Apr 30, 2024
Bryce-Soghigian
approved these changes
Apr 30, 2024
Pull Request Test Coverage Report for Build 8904687976Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nodeClass.Spec.OSDiskSizeGB dereference actually crashes when being called from the cloudprovider GetInstanceTypes if the nodepool is nil.
Fixes #315
Description
How was this change tested?
Does this change impact docs?
Release Note