Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: using lo.FromPtr is safer than directly accessing the pointer #316

Merged
merged 2 commits into from
May 1, 2024
Merged

chore: using lo.FromPtr is safer than directly accessing the pointer #316

merged 2 commits into from
May 1, 2024

Commits on Apr 30, 2024

  1. chore: using lo.FromPtr is safer than directly accessing the pointer 

    The nodeClass.Spec.OSDiskSizeGB dereference actually crashes when
being called from the Azure cloudprovider GetInstanceTypes if the
nodepool is nil.

Signed-off-by: Ukri Niemimuukko <ukri.niemimuukko@intel.com>
    @uniemimu
    uniemimu committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    73e7d34 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Merge branch 'main' into ephemeral

    @tallaxes
    tallaxes authored May 1, 2024
    Configuration menu
    Copy the full SHA
    97f085f View commit details
    Browse the repository at this point in the history