Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[subintf & mirror] Mirror monitor port via a local sub port router interface #1727

Open
wants to merge 59 commits into
base: master
Choose a base branch
from

Conversation

wendani
Copy link
Contributor

@wendani wendani commented Apr 26, 2021

What I did
Deal with the possibility that the chosen next hop object goes through a local sub port router interface

Why I did it
Mirror destination lookup is done in default VRF. As a sub port router interface can be the local router interface of the next hop or next hop group member of an ip prefix in default VRF, here we deal with such a likelihood.

How I verified it
Newly added vs tests:

  • Mirror session add removal, together with the following update event MirrorOrch observes:
  • Mirror session status update at parent port oper status change for the case of mirror destination in directly connected subnet (depends on [mirror] Update session status at port oper status change for mirror destination in directly connected subnet case #1725)
    • neighbor mac update
    • neighbor mac removal and add
  • Next hop group update on LPM ip prefix that causes monitor port (Mirror to port) to migrate from via a local sub port router interface to via other local RIFs, and vice versa. Validate a local RIF migrated to/back from being one of the following types:
    • EthernetX
    • PortChannelX
    • Vlan interface of the same vlan id
    • Vlan interface of a different vlan id
    • EthernetX.Y sub port interface
    • PortChannelX.Y sub port interface
  • LPM ip prefix update that causes monitor port (Mirror to port) to migrate from via a local sub port router interface to via other local RIFs, and vice versa. Validate a local RIF migrated to/back from being one of the types listed above.
  • ERSPAN ipv6 encap (depends on [mirror] erspan ipv6 underlay #1817)

Details if related
Contains (dependency on) #1725

wendani added 30 commits April 8, 2021 01:41
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
wendani added 3 commits April 26, 2021 22:09
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani wendani changed the title [subintf] Mirror via a local sub port router interface [subintf] Mirror monitor port via a local sub port router interface Apr 28, 2021
@lguohan lguohan added the subport label May 7, 2021
wendani added 12 commits May 25, 2021 18:17
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
MirrorToLagAddRemove

Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani wendani requested a review from prsunny as a code owner July 11, 2021 07:07
@prsunny prsunny requested a review from neethajohn July 14, 2021 20:58
@prsunny
Copy link
Collaborator

prsunny commented Jul 14, 2021

Test failures?

@wendani wendani changed the title [subintf] Mirror monitor port via a local sub port router interface [subintf & mirror] Mirror monitor port via a local sub port router interface Jul 20, 2021
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
include changes:
0031470 |  improve enum values integration check (sonic-net#1727) (sonic-net#1737)

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants