Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mirror] erspan ipv6 underlay #1817

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open

[mirror] erspan ipv6 underlay #1817

wants to merge 36 commits into from

Conversation

wendani
Copy link
Contributor

@wendani wendani commented Jul 9, 2021 •
edited
Loading

Why I did it
Unlock erspan capability on td3 and beyond that supports erspan ipv6 encap.

What I did

How I verified it

  1. Extend test_MirrorAddSetRemove, test_MirrorToVlanAddRemove, test_MirrorToLagAddRemove, test_MirrorDestMoveVlan, test_MirrorDestMoveLag to vs test erspan ipv6 encap

  2. On td3

Details if related

Used brcm sai 4.3.3 that interacts with sdk 6.5.21

wendani and others added 24 commits July 6, 2021 20:49
@wendani
erspan ipv6 underlay
7da16c0 
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
@wendani
Introduce src, dst ips
d0c5d5f 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Introduce interface address
0c79782 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Introduce next hop ip
f60b974 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Refactor route add
726e600 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
test MirrorAddRemove ipv6 encap
e9ecc9b 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Refactor MirrorToLagAddRemove
090410f 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Uncomment test
cd2c779 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Introduce _test_MirrorToLagAddRemove
f9c211c 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
test MirrorToLagAddRemove ipv6 encap
ad07aa5 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Refactor MirrorToVlanAddRemove
61149a5 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Introduce _test_MirrorToVlanAddRemove
af5e1e1 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
test MirrorToVlanAddRemove ipv6 encap
6e96186 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
test_MirrorToLagAddRemove check IPHDR_VERSION
21ce117 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Refactor MirrorDestMoveVlan
12d4267 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Introduce _test_MirrorDestMoveVlan
fbed725 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
test MirrorDestMoveVlan ipv6 encap
1e24562 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Refactor MirrorDestMoveLag
8f45af5 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Introduce _test_MirrorDestMoveLag
ca4dbf3 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
test MirrorDestMoveLag ipv6 encap
320efa0 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Merge remote-tracking branch 'public/master' into v6erspan_master
9744601
@wendani
ipv6 next hop key
fef1dfa 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Add missing test run
07689ba 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Add comment
b2f8475 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani wendani requested a review from prsunny as a code owner July 9, 2021 22:13
@wendani wendani mentioned this pull request Jul 9, 2021
Closed
@lgtm-com
Copy link

lgtm-com bot commented Jul 9, 2021

This pull request fixes 1 alert when merging b2f8475 into 64e33b3 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@wendani
Address comment: use !isV4() for ipv6
f25b22f 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Jul 15, 2021

This pull request fixes 1 alert when merging f25b22f into 64e33b3 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@prsunny
Copy link
Collaborator

prsunny commented Jul 16, 2021

/azp run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lgtm-com
Copy link

lgtm-com bot commented Dec 20, 2021

This pull request fixes 1 alert when merging 9ea7873 into a4c80c3 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@wendani
Copy link
Contributor Author

wendani commented Dec 23, 2021

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lgtm-com
Copy link

lgtm-com bot commented Jan 10, 2022

This pull request fixes 1 alert when merging d988374 into 43e54e5 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Jan 11, 2022

This pull request fixes 1 alert when merging 05a5c98 into 8fd6e48 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@prsunny
Copy link
Collaborator

prsunny commented Jan 26, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Oct 2, 2024 •
edited
Loading

CLA Not Signed

@prsunny
Copy link
Collaborator

prsunny commented Oct 2, 2024

/easycla

mramezani95 pushed a commit to mramezani95/sonic-swss that referenced this pull request Oct 8, 2024
Applied changed in PR sonic-net#1817
57034ae
mramezani95 added a commit to mramezani95/sonic-swss that referenced this pull request Oct 8, 2024
@mramezani95
Applied changes from PR sonic-net#1817
f56a549 
Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>
@mramezani95 mramezani95 mentioned this pull request Oct 8, 2024
Merged
@mramezani95
Copy link
Contributor

Copied all changes in this PR to PR #3317.

mramezani95 added a commit to mramezani95/sonic-swss that referenced this pull request Oct 15, 2024
@mramezani95
Applied changes from PR sonic-net#1817
0c74e0d 
Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>
prsunny pushed a commit that referenced this pull request Nov 18, 2024
@mramezani95
[mirror] erspan ipv6 underlay (see PR #1817) (#3317)
c865803 
* Applied changes from PR #1817
Why I did it
Unlock erspan capability on td3 and beyond that supports erspan ipv6 encap.

What I did
Extend test_MirrorAddSetRemove, test_MirrorToVlanAddRemove, test_MirrorToLagAddRemove, test_MirrorDestMoveVlan, test_MirrorDestMoveLag to vs test erspan ipv6 encap
On td3
github-actions bot pushed a commit to bradh352/sonic-swss that referenced this pull request Nov 19, 2024
@mramezani95 @github-actions
[mirror] erspan ipv6 underlay (see PR sonic-net#1817) (sonic-net#3317)
36baab1 
* Applied changes from PR sonic-net#1817
Why I did it
Unlock erspan capability on td3 and beyond that supports erspan ipv6 encap.

What I did
Extend test_MirrorAddSetRemove, test_MirrorToVlanAddRemove, test_MirrorToLagAddRemove, test_MirrorDestMoveVlan, test_MirrorDestMoveLag to vs test erspan ipv6 encap
On td3
bradh352 pushed a commit to bradh352/sonic-swss that referenced this pull request Nov 19, 2024
@mramezani95 @bradh352
[mirror] erspan ipv6 underlay (see PR sonic-net#1817) (sonic-net#3317)
c402cbe 
* Applied changes from PR sonic-net#1817
Why I did it
Unlock erspan capability on td3 and beyond that supports erspan ipv6 encap.

What I did
Extend test_MirrorAddSetRemove, test_MirrorToVlanAddRemove, test_MirrorToLagAddRemove, test_MirrorDestMoveVlan, test_MirrorDestMoveLag to vs test erspan ipv6 encap
On td3
mlok-nokia pushed a commit to mlok-nokia/sonic-swss that referenced this pull request Nov 22, 2024
@mramezani95 @mlok-nokia
[mirror] erspan ipv6 underlay (see PR sonic-net#1817) (sonic-net#3317)
c6e54ca 
* Applied changes from PR sonic-net#1817
Why I did it
Unlock erspan capability on td3 and beyond that supports erspan ipv6 encap.

What I did
Extend test_MirrorAddSetRemove, test_MirrorToVlanAddRemove, test_MirrorToLagAddRemove, test_MirrorDestMoveVlan, test_MirrorDestMoveLag to vs test erspan ipv6 encap
On td3
bradh352 pushed a commit to bradh352/sonic-swss that referenced this pull request Dec 4, 2024
@mramezani95 @bradh352
[mirror] erspan ipv6 underlay (see PR sonic-net#1817) (sonic-net#3317)
c7c8718 
* Applied changes from PR sonic-net#1817
Why I did it
Unlock erspan capability on td3 and beyond that supports erspan ipv6 encap.

What I did
Extend test_MirrorAddSetRemove, test_MirrorToVlanAddRemove, test_MirrorToLagAddRemove, test_MirrorDestMoveVlan, test_MirrorDestMoveLag to vs test erspan ipv6 encap
On td3
divyachandralekha pushed a commit to divyachandralekha/sonic-swss that referenced this pull request Dec 12, 2024
@mramezani95 @divyachandralekha
[mirror] erspan ipv6 underlay (see PR sonic-net#1817) (sonic-net#3317)
cd5913c 
* Applied changes from PR sonic-net#1817
Why I did it
Unlock erspan capability on td3 and beyond that supports erspan ipv6 encap.

What I did
Extend test_MirrorAddSetRemove, test_MirrorToVlanAddRemove, test_MirrorToLagAddRemove, test_MirrorDestMoveVlan, test_MirrorDestMoveLag to vs test erspan ipv6 encap
On td3
divyachandralekha pushed a commit to divyachandralekha/sonic-swss that referenced this pull request Dec 12, 2024
@mramezani95 @divyachandralekha
[mirror] erspan ipv6 underlay (see PR sonic-net#1817) (sonic-net#3317)
09f4159 
* Applied changes from PR sonic-net#1817
Why I did it
Unlock erspan capability on td3 and beyond that supports erspan ipv6 encap.

What I did
Extend test_MirrorAddSetRemove, test_MirrorToVlanAddRemove, test_MirrorToLagAddRemove, test_MirrorDestMoveVlan, test_MirrorDestMoveLag to vs test erspan ipv6 encap
On td3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bingwang-ms bingwang-ms bingwang-ms approved these changes

@prsunny prsunny prsunny left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wendani @prsunny @mssonicbld @bingwang-ms @mramezani95