Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ip address] Add isV6() helper member function #502

Closed
wants to merge 2 commits into from
Closed

[ip address] Add isV6() helper member function #502

wants to merge 2 commits into from

Conversation

wendani
Copy link
Contributor

@wendani wendani commented Jul 9, 2021

@wendani wendani mentioned this pull request Jul 9, 2021
Open
prsunny
prsunny reviewed Jul 14, 2021
View reviewed changes
common/ipaddress.h
@@ -29,6 +29,11 @@ class IpAddress
return m_ip.family == AF_INET;
}

inline bool isV6() const
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so far, we've been using this as !isV4(). Looks like its needed for certain cases?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Thanks for pointing out. This then is not needed.

@wendani wendani closed this Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prsunny prsunny prsunny left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wendani @prsunny