Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VWAN deployment capability #287

Merged
merged 42 commits into from
Mar 9, 2022
Merged

Add VWAN deployment capability #287

merged 42 commits into from
Mar 9, 2022

Conversation

krowlandson
Copy link
Contributor

@krowlandson krowlandson commented Mar 1, 2022 •
edited
Loading

Overview/Summary

This PR adds VWAN deployment capability to the module, and updates the test framework to provide coverage for this.

Documentation is to follow, and there are a few areas which will be updated before the next release for both VWAN and H&S network topologies (e.g. adding support for firewall policy creation).

Update to the What's New page in the ES wiki will be added upon release, not specifically for this PR

This PR fixes/adds/changes/removes

  1. Add resources for VWAN connectivity option to fix Add capability for "Virtual WAN Networking" resources - Connectivity Subscription #226
  2. Update test framework to include VWAN resources and implement the configuration in stages to better reflect a typical user journey for deploying and updating configuration settings
  3. Partial coverage for Replace try() with lookup() where possible #227
  4. Update minimum supported version to fix Error: deleting Azure Firewall #271
  5. Fix Argument management_group_name deprecated in favour of management_group_id #272
  6. Fix azurerm_role_assignment.policy_assignment resources outputs missing #273

Breaking Changes

  1. Change to minimum supported provider version may require customers to update their code and run terraform init -upgrade

Testing Evidence

to follow

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located in the Enterprise-Scale repo in the directory: /docs/wiki/whats-new.md)

Kevin Rowlandson added 6 commits January 11, 2022 15:45
Add VWAN capabilities to upstream branch (#250)
8f83a88 
* Initial MVP for virtual wan and hub resources
* Update resource dependencies
* Refactor to create dedicated resources for vwan
* Refactor to simplify for management resources
* Replace `try()` with `lookup()`
* Update custom settings for Virtual WAN
* Add DNS links for spokes connected to Virtual Hubs
* Add virtual hub connections
Fix incorrect VPN gateway name (#251)
484e2c6 
* Fix incorrect VPN gateway name
Merge remote-tracking branch 'upstream/main' into vwan
2ae6cc5
Refactor test framework for VWAN additions (#265)
8de9bc6 
* Refactor test deployments

* Update minimum supported provider version

* Fix linting error

* Update root_name

* Update unit test pipeline

* Fix certificate path error

* Rename job display names

* Update e2e test pipeline

* Update location variable

* Remove unused TF_PLAN_OUT variable

* Update parallelism environment variable

* Update path for terraform destroy

* Increase job timeouts for e2e

* Update OPA value generator for pwsh

* Add `planned_values.json` for each test case

* Remove trailing whitespace

* Update OPA tests script for new framework

* Add OPA tasks to Unit Tests job

* Remove `.sh` script (to be unified with `.ps1` version)

* Refactor OPA installation scripts

* Update execution bit

* Update task names

* Add readme to test framework

* Add VWAN config to connectivity settings

* Remove unsupported tags object from config

* Update minimum supported version to fix #271

* Fix #271 error deleting firewall

* Updates to fix #272

* Fix formatting error on fix for #273

* Fix to prevent lock file versions error

* Update rego files to reflect changes for #272

* Updated for latest test framework plans
Merge remote-tracking branch 'upstream/main' into vwan
66c9bc1
Update conftest baseline
adacc85
@krowlandson krowlandson added the enhancement New feature or request label Mar 1, 2022
@krowlandson krowlandson added this to the v1.2.0 release milestone Mar 1, 2022
@krowlandson krowlandson self-assigned this Mar 1, 2022
@krowlandson
Copy link
Contributor Author

/azp run unit

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krowlandson
Copy link
Contributor Author

/azp run unit

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@krowlandson
Copy link
Contributor Author

/azp run unit

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@matt-FFFFFF
Copy link
Member

Looks great! Only comment is can we split locals.connectivity into smaller files to make reading easier? @krowlandson

@krowlandson
Copy link
Contributor Author

krowlandson commented Mar 7, 2022 •
edited
Loading

Looks great! Only comment is can we split locals.connectivity into smaller files to make reading easier? @krowlandson Kevin Rowlandson FTE

Do we need this now, or tackle as part of adding in all the extra logic to further remove try() functions as per #227?

@krowlandson krowlandson marked this pull request as ready for review March 7, 2022 11:55
matt-FFFFFF
matt-FFFFFF approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@matt-FFFFFF matt-FFFFFF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E changes working so :shipit:

@krowlandson
Copy link
Contributor Author

/azp run unit

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@matt-FFFFFF matt-FFFFFF mentioned this pull request Mar 9, 2022
Merged
6 tasks
@krowlandson krowlandson merged commit 739a3f9 into main Mar 9, 2022
@krowlandson krowlandson deleted the vwan branch March 9, 2022 14:16
@krowlandson krowlandson mentioned this pull request Mar 10, 2022
Closed
@krowlandson krowlandson mentioned this pull request Mar 30, 2022
Closed
@krowlandson krowlandson mentioned this pull request Apr 8, 2022
Merged
6 tasks
@mlomat
Copy link

mlomat commented Apr 14, 2022

@krowlandson Do you have any documentation or example for Virtual Hub deployment? Or is it placeholder only for future use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-FFFFFF matt-FFFFFF matt-FFFFFF approved these changes

@jtracey93 jtracey93 Awaiting requested review from jtracey93

Assignees

@krowlandson krowlandson

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.0.0 release
3 participants
@krowlandson @matt-FFFFFF @mlomat