-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support arm arch and delete unused file #76
Conversation
Codecov Report
@@ Coverage Diff @@
## main #76 +/- ##
==========================================
- Coverage 66.93% 66.84% -0.09%
==========================================
Files 33 33
Lines 2752 2745 -7
Branches 105 105
==========================================
- Hits 1842 1835 -7
Misses 909 909
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
src/clients/CliVersionsClient.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cxznmhdcxz completed E2E testing and this file was not referred anywhere and didn't cause any issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉🙏 thank you so much for the ping for review, added couple of comments but rest looks good, thanks
This PR support the following
This is tested in ubuntu arm - works without any issues. E2E testing is still pending.