Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support arm arch and delete unused file #76

Merged
merged 4 commits into from
Nov 28, 2023

Conversation

hsubramanianaks
Copy link
Collaborator

@hsubramanianaks hsubramanianaks commented Oct 11, 2023

This PR support the following

  1. downloading arm/arm64 binaries based on where the extension is running. Also depends on this PR from CLI repo - initial changes for including arm64 binaries Bridge-To-Kubernetes#290
  2. Also removed an used file along with this.
  3. Updated minimum kubectl version to 1.27.3
    This is tested in ubuntu arm - works without any issues. E2E testing is still pending.

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

Merging #76 (596ff4a) into main (5fd56ce) will decrease coverage by 0.09%.
Report is 7 commits behind head on main.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
- Coverage   66.93%   66.84%   -0.09%     
==========================================
  Files          33       33              
  Lines        2752     2745       -7     
  Branches      105      105              
==========================================
- Hits         1842     1835       -7     
  Misses        909      909              
  Partials        1        1              
Flag Coverage Δ
unittests 66.84% <25.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Constants.ts 100.00% <100.00%> (ø)
src/clients/BinariesVersionClient.ts 27.34% <0.00%> (ø)

... and 2 files with indirect coverage changes

@hsubramanianaks hsubramanianaks marked this pull request as ready for review October 27, 2023 21:04
@hsubramanianaks hsubramanianaks added the enhancement 🧑‍🔧💡 New feature or request label Oct 27, 2023
Copy link
Member

@Tatsinnit Tatsinnit Nov 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 note please - I am sure comment meant to say unused, but please make sure this is not used anywhere. Thanks

IMG_9011

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cxznmhdcxz completed E2E testing and this file was not referred anywhere and didn't cause any issues.

Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🙏 thank you so much for the ping for review, added couple of comments but rest looks good, thanks

@hsubramanianaks hsubramanianaks merged commit e63cdcd into Azure:main Nov 28, 2023
4 checks passed
@hsubramanianaks hsubramanianaks deleted the support-arm-arch branch November 28, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🧑‍🔧💡 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants