Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support arm arch and delete unused file #76

Merged
merged 4 commits into from
Nov 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export class Constants {
public static readonly BridgeDownloadDirectoryName = `bridge`;
public static readonly KubectlDownloadDirectoryName = `kubectl`;
public static readonly DotNetDownloadDirectoryName = `dotnet`;
public static readonly KubectlMinVersion = `1.21.2`;
public static readonly KubectlMinVersion = `1.27.3`;
hsubramanianaks marked this conversation as resolved.
Show resolved Hide resolved
public static readonly DotNetMinVersion = `7.0.7`;

/* BinariesUtility Constants */
Expand Down
6 changes: 3 additions & 3 deletions src/clients/BinariesVersionClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -92,11 +92,11 @@ export class BinariesVersionClient {
private getOsString(): string {
switch (process.platform) {
case `win32`:
return `win`;
return process.arch && process.arch === 'arm64' ? `win_arm64` : `win`;
case `darwin`:
return `osx`;
return process.arch && process.arch === 'arm64' ? `osx_arm64` : `osx`;
case `linux`:
return `linux`;
return process.arch && process.arch === 'arm64' ? `linux_arm64` : `linux`;
default:
const error = new Error(`Unsupported platform: ${process.platform}`);
this._logger.error(TelemetryEvent.UnexpectedError, error);
Expand Down
93 changes: 0 additions & 93 deletions src/clients/CliVersionsClient.ts

This file was deleted.

Loading