Fix issue with .NET Core 3.1 project template domain value, not the same as .NET 5.0 / not recognized by msidentity-app-sync #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmprieur
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
|
@jmprieur let's merge and we'll test later and make changes as needed. just don't want it sitting around |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ASP.NET 5.0 templates use the following value for the "Domain": "qualified.domain.name"
and this is the value recognized by msidentity-app-sync.
We need to check if the same does not need to be changed in the other web app templates (mvc, webapp, and blazorserver)