Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix domain issue for other templates #1150

Merged
merged 1 commit into from
Apr 20, 2021
Merged

fix domain issue for other templates #1150

merged 1 commit into from
Apr 20, 2021

Conversation

jennyf19
Copy link
Collaborator

I think I found all the discrepancies w/domain, but have not built all the templates yet.

@jennyf19 jennyf19 requested a review from jmprieur April 19, 2021 23:19
jmprieur
jmprieur approved these changes Apr 20, 2021
View reviewed changes
Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jennyf19
I have not tested the templates either.

Do we want to merge your branch into Fix1148, and then test there?

@jennyf19 jennyf19 merged commit b314ea8 into jmprieur/Fix1148 Apr 20, 2021
@jennyf19 jennyf19 deleted the jennyf/1148 branch April 20, 2021 15:50
jennyf19 added a commit that referenced this pull request Apr 21, 2021
@jmprieur @jennyf19
Fix issue with .NET Core 3.1 project template domain value, not the s…
bba91c4 
…ame as .NET 5.0 / not recognized by msidentity-app-sync (#1149)

* Update appsettings.json

* fix domain issue for other templates (#1150)

Co-authored-by: jennyf19 <jeferrie@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmprieur jmprieur jmprieur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennyf19 @jmprieur