Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix phpcs error, restrict buttons to non glossary page, apply standards #44

Merged
merged 1 commit into from
Aug 9, 2018
Merged

fix phpcs error, restrict buttons to non glossary page, apply standards #44

merged 1 commit into from
Aug 9, 2018

Conversation

bdolor
Copy link

@bdolor bdolor commented Aug 9, 2018

addresses #40

  • intent is to not display glossary buttons on glossary editing page.
  • phpcs error had to do with line 187 attempting to send an array into a translating function.
    image

@bdolor bdolor requested a review from alex-418 August 9, 2018 19:34
@alex-418 alex-418 merged commit 7f27319 into glossary Aug 9, 2018
@alex-418 alex-418 deleted the wysiwyg branch August 9, 2018 20:58
@bdolor bdolor mentioned this pull request Aug 9, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-418 alex-418 Awaiting requested review from alex-418

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdolor @alex-418