Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ADAM container commit version #72

Merged
merged 1 commit into from
Jan 25, 2016

Conversation

fnothaft
Copy link
Contributor

Lock ADAM docker container to bigdatagenomics/adam@cd6ef41 which is bigdatagenomics/adam#921.

@cgcloud-jenkins
Copy link

Can one of the admins verify this patch?

@heuermh
Copy link
Member

heuermh commented Jan 15, 2016

tests ok for me

@hannes-ucsc
Copy link
Contributor

Jenkins, test this please.

@hannes-ucsc
Copy link
Contributor

Is this still needed?

@fnothaft
Copy link
Contributor Author

Yes-I didn't realize it had merge conflicts. I will resolve those tomorrow.

@fnothaft
Copy link
Contributor Author

@hannes-ucsc merge conflicts are fixed; please merge.

jvivian added a commit that referenced this pull request Jan 25, 2016
Update ADAM container commit version
@jvivian jvivian merged commit 21f4605 into BD2KGenomics:master Jan 25, 2016
@heuermh
Copy link
Member

heuermh commented Jan 25, 2016

In order to build this after merge, I had to use docker build --no-cache ....

The build fails with

$ make
...
Step 6 : RUN git checkout cd6ef4162ae97460059ef067d21bbed7e060b289
 ---> Running in 4a0f271a4f96
Note: checking out 'cd6ef4162ae97460059ef067d21bbed7e060b289'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b new_branch_name

HEAD is now at cd6ef41... Merge pull request #921 from fnothaft/project-out-tags
 ---> 4d2f091ca585
Removing intermediate container 4a0f271a4f96
Step 7 : RUN /opt/apache-maven-3.3.3/bin/mvn package -DskipTests
 ---> Running in 97d43876f86e
...
 ---> 15c7fe79fe27
Removing intermediate container 97d43876f86e
Successfully built 15c7fe79fe27
echo /Users/heuermh/working/cgl-docker-lib/adam/runtime
/Users/heuermh/working/cgl-docker-lib/adam/runtime
docker run -v /Users/heuermh/working/cgl-docker-lib/adam/runtime:/data quay.io/ucsc_cgl/adam:cd6ef41-build cp -r /home/adam /data/adam
cp: cannot create symbolic link '/data/adam/adam/adam-apis/src/test/resources/small.sam': Protocol error
cp: cannot create symbolic link '/data/adam/adam/adam-cli/src/test/resources/ordered.sam': Protocol error
cp: cannot create symbolic link '/data/adam/adam/adam-cli/src/test/resources/unordered.sam': Protocol error
make: *** [runtime/adam] Error 1

I believe I've seen this before but don't remember how we resolved it. Would it be worth replacing the linked test resources in adam with copies instead?

@hannes-ucsc
Copy link
Contributor

Is a virtualbox involved? I've seen mention of this error in relation to the shared host file system that virtualbox uses.

@heuermh
Copy link
Member

heuermh commented Jan 25, 2016

Yup, on OSX docker-machine uses virtualbox, or at least that is how I'm using it. I think you're right, that it is a problem with symbolic links on virtualbox fs.

In any case, should be solved by bigdatagenomics/adam#927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants