Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock down the ADAM version. #83

Merged
merged 1 commit into from
Jan 15, 2016
Merged

Conversation

fnothaft
Copy link
Contributor

@heuermh
Copy link
Member

heuermh commented Jan 15, 2016

+1

@fnothaft
Copy link
Contributor Author

Actually, I think I'm going to need to bump the version of ADAM. Let's hold on this 1 sec. Ran into something when testing last night.

@fnothaft
Copy link
Contributor Author

Specifically, I'd like to get bigdatagenomics/adam#921 in. @heuermh can you review/merge on ADAM and I'll bump here and at cgl-docker-lib?

@heuermh
Copy link
Member

heuermh commented Jan 15, 2016

Merged #921, go ahead

@hannes-ucsc
Copy link
Contributor

Should we create a special, toil-specific branch in the ADAM repo and refer to that branch instead of a specific commit sha1 in the Dockerfile? That branch would get merged into from master whenever you want the container to be updated. Then you just rebuild the containers. That way we don't need to update this Dockerfile everytime a relevant update is made to ADAM. I'm sure their will be more fixes.

@fnothaft
Copy link
Contributor Author

Updated. Good to go from my side, pending BD2KGenomics/cgl-docker-lib#72.

@heuermh
Copy link
Member

heuermh commented Jan 15, 2016

I'm not sure whether we should keep bumping the commit, use a toil-specific branch, or cut a 0.19.0 release of ADAM. What is the reason not to use head at this point?

@fnothaft
Copy link
Contributor Author

I'd like to cut a 0.19.0... once we've got the requisite issues closed.

I prefer a commit to latest/a toil branch in ADAM because if you fetch the commit and it fails, then you get an error message, viz BD2KGenomics/cgl-docker-lib#71. I see this as a feature, not a bug --> it ensures that we're all running the exact same code.

@heuermh
Copy link
Member

heuermh commented Jan 15, 2016

Agreed.

@jpdna when creating the notebook documentation you may wish to mention specific commit revisions or script a checkout for the cgcloud, toil, and toil-scripts repositories as well.

hannes-ucsc added a commit that referenced this pull request Jan 15, 2016
Lock down the ADAM version.
@hannes-ucsc hannes-ucsc merged commit 3a34eb1 into BD2KGenomics:master Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants