Web: fix factorization of project-specific code #2318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user.inc had some code to show icons for users who have donated. This wasn't properly factored - e.g. it made assumptions about how donations are represented. The right way to do this is to use project-defined functions that are called if they're defined (e.g. in project.inc). In this case we needed two such functions: project_user_summary_public() adds a row to a user page, and project_user_links() appends items to the user info shown e.g. in forums This functions can show donation info, or anything else the project wants. AFAIK this affects only SETI@home.
- don't refer to project/donations.inc.
Projects can put functions wherever they want, generally in project.inc
- check for existence of project_user_page_private() before calling it
|
@davidpanderson - Does Seti@Home use this? I'll bug Eric to review it if he does. |
|
Yes. This change is for the benefit of SETI@home, and is deployed there now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.