Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web: fix factorization of project-specific code #2318

Merged
merged 2 commits into from
Jan 30, 2018
Merged

Web: fix factorization of project-specific code #2318

merged 2 commits into from
Jan 30, 2018

Commits on Jan 24, 2018

  1. web: properly factor project-specific donation code 

    user.inc had some code to show icons for users who have donated.
This wasn't properly factored - e.g. it made assumptions
about how donations are represented.

The right way to do this is to use project-defined functions
that are called if they're defined (e.g. in project.inc).
In this case we needed two such functions:
project_user_summary_public() adds a row to a user page, and
project_user_links() appends items to the user info shown e.g. in forums
This functions can show donation info, or anything else the project wants.

AFAIK this affects only SETI@home.
    @davidpanderson
    davidpanderson committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    840d01d View commit details
    Browse the repository at this point in the history

  2. web: more fixes to factoring of project-specific content 

    - don't refer to project/donations.inc.
    Projects can put functions wherever they want, generally in project.inc
- check for existence of project_user_page_private() before calling it
    @davidpanderson
    davidpanderson committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    ed66386 View commit details
    Browse the repository at this point in the history