Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewer : add environment rotation, intensity and visibility #16069

Merged

Conversation

alexandremottet
Copy link
Contributor

@alexandremottet alexandremottet commented Jan 15, 2025

This add the control over the environment intensity and rotation.

  • The intensity is in addition of the exposure you may want to change the IBL intensity and keep other light point exposed the same way.
  • The rotation is expressed in degress for the attribute environment-rotation to keep it understable for rookie users and in radians for the environmentRotation property in the Viewer class as it is a more "advance" use case. We may want in the future to add the support for multiple units, maybe in another PR or let me know if I should add it to this PR.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 15, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 15, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 15, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 15, 2025

packages/tools/viewer/src/viewer.ts Outdated Show resolved Hide resolved
packages/tools/viewer/src/viewerElement.ts Outdated Show resolved Hide resolved
packages/tools/viewer/src/viewer.ts Outdated Show resolved Hide resolved
packages/tools/viewer/src/viewerElement.ts Outdated Show resolved Hide resolved
packages/tools/viewer/src/viewer.ts Outdated Show resolved Hide resolved
@alexandremottet alexandremottet changed the title Viewer : add environment rotation and intensity Viewer : add environment rotation, intensity and visibility Jan 16, 2025
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 16, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 16, 2025

@ryantrem ryantrem merged commit 0fa2b22 into BabylonJS:master Jan 21, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants