Skip to content

Commit

Permalink
Enable DataVolume GC by default in cluster-deploy
Browse files Browse the repository at this point in the history
Prevent DV-related CI failures in the next kubevirt-bot kubevirtci
bump PR (with bump-cdi), due to:
kubevirt/containerized-data-importer#2421

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
  • Loading branch information
arnongilboa authored and bmordeha committed Sep 28, 2022
1 parent 403eaba commit e370c82
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions hack/cluster-deploy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ set -ex pipefail

DOCKER_TAG=${DOCKER_TAG:-devel}
KUBEVIRT_DEPLOY_CDI=${KUBEVIRT_DEPLOY_CDI:-true}
CDI_DV_GC=${CDI_DV_GC:-false}
CDI_DV_GC=${CDI_DV_GC:-0}

source hack/common.sh
# shellcheck disable=SC1090
Expand Down Expand Up @@ -58,9 +58,7 @@ function _ensure_cdi_deployment() {
_kubectl patch cdi ${cdi_namespace} --type merge -p '{"spec": {"config": {"uploadProxyURLOverride": "'"$override"'"}}}'

# Enable succeeded DataVolume garbage collection
if [[ $CDI_DV_GC != "false" ]]; then
_kubectl patch cdi ${cdi_namespace} --type merge -p '{"spec": {"config": {"dataVolumeTTLSeconds": '"$CDI_DV_GC"'}}}'
fi
_kubectl patch cdi ${cdi_namespace} --type merge -p '{"spec": {"config": {"dataVolumeTTLSeconds": '"$CDI_DV_GC"'}}}'
}

function configure_prometheus() {
Expand Down

0 comments on commit e370c82

Please sign in to comment.