Enable DataVolume garbage collection by default #2421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note
arnongilboa
force-pushed
the
cdiconfig_status_dv_ttl
branch
2 times, most recently
from
df99933
to
8b60b7b
Compare
|
/hold |
kubevirt-bot
added
the
do-not-merge/hold
arnongilboa
force-pushed
the
cdiconfig_status_dv_ttl
branch
from
8b60b7b
to
62e6cd4
Compare
|
/unhold |
kubevirt-bot
added
size/L
and removed
do-not-merge/hold
arnongilboa
force-pushed
the
cdiconfig_status_dv_ttl
branch
4 times, most recently
from
f7ee3e9
to
95b9263
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhenriks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
brybacki
reviewed
Sep 13, 2022
|
/lgtm |
|
/retest |
kubevirt-bot
added
the
needs-rebase
arnongilboa
force-pushed
the
cdiconfig_status_dv_ttl
branch
from
95b9263
to
f2f86e6
Compare
kubevirt-bot
removed
lgtm
arnongilboa
changed the title
akalenyu
reviewed
Sep 15, 2022
| @@ -33,6 +33,11 @@ var _ = Describe("[Upgrade]", func() { | |||
|
|
|||
| table.DescribeTable("[rfe_id:5493]DV status.name is populated after upgrade", func(dvName string) { | |||
There was a problem hiding this comment.
We should consider removing the test case altogether since we no longer "encourage" looking at DVs after they're done.
Or we could keep this test but change it to just ensure upgraded DVs are not GC'd if they shouldn't be
On the next kubevirt-bot Bump kubevirtci PR (with bump-cdi), it will fail on all kubevirtci lanes with tests referring DVs, as the tests IsDataVolumeGC() looks at CDIConfig Spec.DataVolumeTTLSeconds and assumes default is disabled. This should be fixed there. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
arnongilboa
force-pushed
the
cdiconfig_status_dv_ttl
branch
from
f2f86e6
to
91a0343
Compare
brybacki
approved these changes
Sep 16, 2022
| @@ -4961,7 +4961,7 @@ | |||
| "type": "object", | |||
| "properties": { | |||
| "dataVolumeTTLSeconds": { | |||
| "description": "DataVolumeTTLSeconds is the time in seconds after DataVolume completion it can be garbage collected.", | |||
| "description": "DataVolumeTTLSeconds is the time in seconds after DataVolume completion it can be garbage collected. The default is 0 sec. To disable GC use -1.", | |||
|
Maybe you can update the kubevirt test case proactively, before even new kubevirtci is introduced. I suppose the same way it work with HCO? |
Great idea, so simply put 0 instead of false here: |
arnongilboa
added a commit
to arnongilboa/kubevirt
that referenced
this pull request
Sep 16, 2022
Prevent DV-related CI failures in the next kubevirt-bot kubevirtci bump PR (with bump-cdi), due to: kubevirt/containerized-data-importer#2421 Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
Barakmor1
pushed a commit
to Barakmor1/kubevirt
that referenced
this pull request
Sep 28, 2022
Prevent DV-related CI failures in the next kubevirt-bot kubevirtci bump PR (with bump-cdi), due to: kubevirt/containerized-data-importer#2421 Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
arnongilboa
added a commit
to arnongilboa/kubevirt
that referenced
this pull request
Sep 28, 2022
CDI is enabling DataVolume garbage collection by default since: kubevirt/containerized-data-importer#2421 To prevent DV-related CI failures due to the old GC disabled default reference, we enabled GC by default for all lanes in cluster-deploy: kubevirt#8479 With the current fix, we no more need to explicitly enable it by default in cluster-deploy. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
arnongilboa
added a commit
to arnongilboa/kubevirt
that referenced
this pull request
Oct 10, 2022
CDI is enabling DataVolume garbage collection by default since: kubevirt/containerized-data-importer#2421 To prevent DV-related CI failures due to the old GC disabled default reference, we enabled GC by default for all lanes in cluster-deploy: kubevirt#8479 With the current fix, we no more need to explicitly enable it by default in cluster-deploy. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
brianmcarey
pushed a commit
to brianmcarey/kubevirt
that referenced
this pull request
Oct 11, 2022
CDI is enabling DataVolume garbage collection by default since: kubevirt/containerized-data-importer#2421 To prevent DV-related CI failures due to the old GC disabled default reference, we enabled GC by default for all lanes in cluster-deploy: kubevirt#8479 With the current fix, we no more need to explicitly enable it by default in cluster-deploy. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
kubevirt-bot
pushed a commit
to kubevirt-bot/kubevirt
that referenced
this pull request
Oct 19, 2022
CDI is enabling DataVolume garbage collection by default since: kubevirt/containerized-data-importer#2421 To prevent DV-related CI failures due to the old GC disabled default reference, we enabled GC by default for all lanes in cluster-deploy: kubevirt#8479 With the current fix, we no more need to explicitly enable it by default in cluster-deploy. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
Barakmor1
pushed a commit
to Barakmor1/kubevirt
that referenced
this pull request
Oct 26, 2022
CDI is enabling DataVolume garbage collection by default since: kubevirt/containerized-data-importer#2421 To prevent DV-related CI failures due to the old GC disabled default reference, we enabled GC by default for all lanes in cluster-deploy: kubevirt#8479 With the current fix, we no more need to explicitly enable it by default in cluster-deploy. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
PiotrProkop
pushed a commit
to PiotrProkop/kubevirt
that referenced
this pull request
Dec 12, 2022
CDI is enabling DataVolume garbage collection by default since: kubevirt/containerized-data-importer#2421 To prevent DV-related CI failures due to the old GC disabled default reference, we enabled GC by default for all lanes in cluster-deploy: kubevirt#8479 With the current fix, we no more need to explicitly enable it by default in cluster-deploy. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arnon Gilboa agilboa@redhat.com
What this PR does / why we need it:
It's time to enable DataVolume garbage collection by default.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
On the next kubevirt-bot Bump kubevirtci PR (with bump-cdi), it will fail on all kubevirtci lanes with tests referring DVs, as the tests IsDataVolumeGC() looks at CDIConfig Spec.DataVolumeTTLSeconds and assumes default is disabled. This should be fixed there.
Release note: