Skip to content

Commit

Permalink
Merge pull request #4 from KhronosGroup/main
Browse files Browse the repository at this point in the history
Add `static` keyword to avoid -Wmissing-prototypes (KhronosGroup#345)
  • Loading branch information
BattleAxeVR authored Nov 17, 2022
2 parents 4f70f24 + b60b77f commit 4fdd327
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions changes/sdk/pr.345.gh.OpenXR-SDK-Source.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
loader: Minor changes to fix a missing-prototypes warning/error.
4 changes: 3 additions & 1 deletion src/loader/loader_core.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
// Global loader lock to:
// 1. Ensure ActiveLoaderInstance get and set operations are done atomically.
// 2. Ensure RuntimeInterface isn't used to unload the runtime while the runtime is in use.
std::mutex &GetGlobalLoaderMutex() {
static std::mutex &GetGlobalLoaderMutex() {
static std::mutex loader_mutex;
return loader_mutex;
}
Expand All @@ -58,6 +58,8 @@ static XRAPI_ATTR XrResult XRAPI_CALL LoaderXrTermDestroyDebugUtilsMessengerEXT(
static XRAPI_ATTR XrResult XRAPI_CALL LoaderXrTermSubmitDebugUtilsMessageEXT(
XrInstance instance, XrDebugUtilsMessageSeverityFlagsEXT messageSeverity, XrDebugUtilsMessageTypeFlagsEXT messageTypes,
const XrDebugUtilsMessengerCallbackDataEXT *callbackData);
static XRAPI_ATTR XrResult XRAPI_CALL LoaderXrGetInstanceProcAddr(XrInstance instance, const char *name,
PFN_xrVoidFunction *function);

// Utility template function meant to validate if a fixed size string contains
// a null-terminator.
Expand Down

0 comments on commit 4fdd327

Please sign in to comment.