Add static keyword to avoid -Wmissing-prototypes
#345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling the code on mac catalyst (which uses IOS SDK), I ran into a compiler error with `-Werror -Wmissing-prototypes`.
|
|
|
The two CI failures don't seem related to my change. |
|
Yeah, those aren't your fault, not sure why they're happening. Could you add a changelog fragment in changes/sdk called |
rpavlik
approved these changes
Nov 14, 2022
rpavlik
added
in loader
needs changelog fragment
|
An issue (number 1874) has been filed to correspond to this pull request in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#1874 ), to facilitate working group processes. This GitHub pull request will continue to be the main site of discussion. |
|
Thanks! |
BattleAxeVR
added a commit
to BattleAxeVR/OpenXR-SDK-Source
that referenced
this pull request
Nov 17, 2022
Add `static` keyword to avoid -Wmissing-prototypes (KhronosGroup#345)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling the code on mac catalyst (which uses IOS SDK), I ran into a compiler error with
-Werror -Wmissing-prototypes.