fix: extract variable check to pattern base (#1670)

Bearer · Aug 12, 2024 · 145d9ad · 145d9ad
1 parent acc0caf
commit 145d9ad
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/pkg/scanner/detectors/customrule/patternquery/builder/builder.go b/pkg/scanner/detectors/customrule/patternquery/builder/builder.go
@@ -391,7 +391,7 @@ func getVariableFor(
 	}
 
 	for i, variable := range variables {
-		if node.Content() == variable.DummyValue {
+		if patternLanguage.IsVariable(node, variable.DummyValue) {
 			return &variables[i]
 		}
 	}

diff --git a/pkg/scanner/language/pattern.go b/pkg/scanner/language/pattern.go
@@ -113,4 +113,7 @@ type Pattern interface {
 
 	// Handle missing errors
 	FixupMissing(node *tree.Node) string
+
+	// Check if node represents variable with given dummy value
+	IsVariable(node *tree.Node, dummyValue string) bool
 }
diff --git a/pkg/scanner/language/patternbase.go b/pkg/scanner/language/patternbase.go
@@ -39,3 +39,7 @@ func (*PatternBase) AdjustInput(input string) string {
 func (*PatternBase) FixupMissing(node *tree.Node) string {
 	return ""
 }
+
+func (*PatternBase) IsVariable(node *tree.Node, dummyValue string) bool {
+	return node.Content() == dummyValue
+}