Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: extract variable check to pattern base #1670

Merged
merged 1 commit into from
Aug 12, 2024
Merged

fix: extract variable check to pattern base #1670

merged 1 commit into from
Aug 12, 2024

Conversation

elsapet
Copy link
Contributor

@elsapet elsapet commented Aug 12, 2024

Description

Extract variable check to pattern base so we can modify this as needed per language

Checklist

If this is your first time contributing please sign the CLA

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.

@elsapet elsapet requested a review from didroe August 12, 2024 10:31
@elsapet elsapet merged commit 145d9ad into main Aug 12, 2024
7 checks passed
@elsapet elsapet deleted the fix/extract-variable-check-to-pattern-base branch August 12, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didroe didroe didroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elsapet @didroe