Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Switch macOS build to Xcode 12.2 #5995

Closed
wants to merge 4 commits into from
Closed

Conversation

EwoutH
Copy link
Contributor

@EwoutH EwoutH commented Nov 17, 2020

Using Xcode 12.2 opens the road to universal binaries for Apple Silicon

Fixes the CVE-2020-15228 security issue in GitHub Actions:
> `add-path` and `set-env` Runner commands are processed via stdout
set-env was used twice, which is now replaced by  >> $GITHUB_ENV

 - Issue: GHSA-mfwh-5m23-j46w
 - Solution: https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions#setting-an-environment-variable)
Version 3 of libsigc++ was automatically installed. This commit fixates the version brew installs to 2.x.

Should fix Beep6581#6002
Using Xcode 12.2 opens the road to universal binaries for Apple Silicon
@EwoutH
Copy link
Contributor Author

EwoutH commented Nov 21, 2020

Rebased on top of #6004. I would advise merging #6004 first, and then this PR.

@EwoutH
Copy link
Contributor Author

EwoutH commented Nov 21, 2020

You know what, let's close this in favor of #6004. Xcode 12.2 will become the default version of Xcode on November 30th anyway (see actions/runner-images#2056) and I will add a commit to #6004 to update the checkout and upload-artifacts steps to v2.

@EwoutH EwoutH closed this Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant