CI: Fix CVE-2020-15228 in GitHub Actions #6004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the CVE-2020-15228 security issue in GitHub Actions: > `add-path` and `set-env` Runner commands are processed via stdout set-env was used twice, which is now replaced by >> $GITHUB_ENV - Issue: GHSA-mfwh-5m23-j46w - Solution: https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions#setting-an-environment-variable)
Version 3 of libsigc++ was automatically installed. This commit fixates the version brew installs to 2.x. Should fix Beep6581#6002
Also replaces macos-10.15 with macos-latest as runner. Currently is references the same environment (macOS 10.15), but this way it will update to macOS 11.0 when it's ready and stable.
|
@EwoutH Thanks for this 👍 |
|
Great! Thank you @EwoutH ;-) |
|
@heckflosse I don't think there can be any objections here. Thank you @EwoutH ! |
|
Thanks for reviewing and merging so quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the CVE-2020-15228 security issue in GitHub Actions:
set-envwas used twice, which is now replaced by>> $GITHUB_ENVEdit: Also closes #6002.