Add in call to ament_export_targets. #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That way downstream ament packages can use this package as a CMake target. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
7 tasks
|
This is an alternative to my proposal at #778 |
|
I will add this to the main branch too. thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way downstream ament packages can use this
package as a CMake target.
I'll note that I targeted this PR to the v3.8 branch, as that is what I'm compiling against for Navigation2 on Iron right now. But I'm happy to target to another branch, depending on best development practices for this repository.