Skip to content

Commit

Permalink
fix: Remove period in "learn more." button (cypress-io#21935)
Browse files Browse the repository at this point in the history
Co-authored-by: Matt Henkes <mjhenkes@gmail.com>
  • Loading branch information
2 people authored and BeijiYang committed Jun 23, 2022
1 parent a302127 commit 0373b6c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions packages/frontend-shared/src/locales/en-US.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"links": {
"learnMore": "Learn more.",
"learnMoreButton": "Learn more",
"needHelp": "Need help"
},
"components": {
Expand Down
2 changes: 1 addition & 1 deletion packages/launchpad/cypress/e2e/project-setup.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -623,7 +623,7 @@ describe('Launchpad: Setup Project', () => {

cy.findByRole('button', { name: 'Skip' }).click()
cy.intercept('POST', 'mutation-ExternalLink_OpenExternal', { 'data': { 'openExternal': true } }).as('OpenExternal')
cy.findByText('Learn more.').click()
cy.findByText('Learn more').click()
cy.wait('@OpenExternal')
.its('request.body.variables.url')
.should('equal', 'https://on.cypress.io/guides/configuration')
Expand Down
2 changes: 1 addition & 1 deletion packages/launchpad/src/components/code/FileRow.vue
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
class="whitespace-nowrap"
href="https://on.cypress.io/guides/configuration"
>
{{ t('links.learnMore') }}
{{ t('links.learnMoreButton') }}
</Button>
</div>
<ShikiHighlight
Expand Down

0 comments on commit 0373b6c

Please sign in to comment.