Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove period in "learn more." button #21935

Merged
merged 8 commits into from
Jun 8, 2022

Conversation

sainthkh
Copy link
Contributor

User facing changelog

Remove period from "Learn More." button.

Additional details

  • Why was this change necessary? => It's really unusual to have a period at the end of a button.
  • What is affected by this change? => N/A

Any implementation details to explain?

I thought there are 3 ways to solve this problem:

  1. Removing period from "Learn More." text.
  2. create a tp function that automatically adds '.' at the end of the text.
  3. create a new text entry without a period.

I chose 3. Here are reasons.

Why not 1?

It's because it's working perfectly in the project settings page of app.

image

Why not 2?

It's because some languages (like Chinese and Japanese) don't use . as their period. They use instead.

Why 3?

It's redundant. But it's the safest way to support all languages on earth.

Steps to test

On project setup page,

image

How has the user experience changed?

Before:

image

After:

image

PR Tasks

  • Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 31, 2022

Thanks for taking the time to open a PR!

@sainthkh sainthkh marked this pull request as ready for review May 31, 2022 07:04
@jennifer-shehane
Copy link
Member

Thanks @sainthkh! We migrated a bunch of issues we had internally for our new 10.0 UI, so I'm sure you can see there are lots of other issues to pick off from that are simple fixed. I added a 'good first issue' to some of them. Thanks again.

@flotwig flotwig merged commit 406a193 into cypress-io:develop Jun 8, 2022
BeijiYang pushed a commit to BeijiYang/cypress that referenced this pull request Jun 23, 2022
Co-authored-by: Matt Henkes <mjhenkes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove punctuation from 'Learn more.' button in UI
4 participants