fix: Remove period in "learn more." button #21935
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Remove period from "Learn More." button.
Additional details
Any implementation details to explain?
I thought there are 3 ways to solve this problem:
tp
function that automatically adds '.' at the end of the text.I chose 3. Here are reasons.
Why not 1?
It's because it's working perfectly in the project settings page of
app
.Why not 2?
It's because some languages (like Chinese and Japanese) don't use
.
as their period. They use。
instead.Why 3?
It's redundant. But it's the safest way to support all languages on earth.
Steps to test
On project setup page,
How has the user experience changed?
Before:
After:
PR Tasks
cypress-documentation
?type definitions
?