Skip to content

Commit

Permalink
fix: Remove period in "learn more." button (#21935)
Browse files Browse the repository at this point in the history
Co-authored-by: Matt Henkes <mjhenkes@gmail.com>
  • Loading branch information
sainthkh and mjhenkes authored Jun 8, 2022
1 parent f9d9d38 commit 406a193
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions packages/frontend-shared/src/locales/en-US.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"links": {
"learnMore": "Learn more.",
"learnMoreButton": "Learn more",
"needHelp": "Need help"
},
"components": {
Expand Down
2 changes: 1 addition & 1 deletion packages/launchpad/cypress/e2e/project-setup.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -623,7 +623,7 @@ describe('Launchpad: Setup Project', () => {

cy.findByRole('button', { name: 'Skip' }).click()
cy.intercept('POST', 'mutation-ExternalLink_OpenExternal', { 'data': { 'openExternal': true } }).as('OpenExternal')
cy.findByText('Learn more.').click()
cy.findByText('Learn more').click()
cy.wait('@OpenExternal')
.its('request.body.variables.url')
.should('equal', 'https://on.cypress.io/guides/configuration')
Expand Down
2 changes: 1 addition & 1 deletion packages/launchpad/src/components/code/FileRow.vue
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
class="whitespace-nowrap"
href="https://on.cypress.io/guides/configuration"
>
{{ t('links.learnMore') }}
{{ t('links.learnMoreButton') }}
</Button>
</div>
<ShikiHighlight
Expand Down

2 comments on commit 406a193

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 406a193 Jun 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.1.0/linux-x64/develop-406a19303bdd53673de5b101d76fd221a36f4e13/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 406a193 Jun 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.1.0/darwin-x64/develop-406a19303bdd53673de5b101d76fd221a36f4e13/cypress.tgz

Please sign in to comment.