Bazel issue 13553 desugar workaround

[Bencodes]

PR demonstrating how to work around the desugaring bug that was introduced in the latest version of Kotlin.

[Bencodes]

This actually needs to be a kt_jvm_import to preserve the Kotlin metadata

[Bencodes]

You also need to supply the srcjar here if you want to use the Intellij aspects

[nkoroste]

What's the actual fix? just curious

[chancila]

line 15 in the BUILD file

[Kernald]

Looks like this isn't really possible anymore with rules_jvm_external 4.3 and above - the jar isn't visible anymore. (Probably?) caused by bazel-contrib/rules_jvm_external#649.

[Bencodes]

@Kernald it's still possible and I made some changes inside rules jvm external to make it easier. I'll try to update this PR today with the new way.

[Bencodes]

@Kernald This actually seems to have been fixed using the latest rolling release (6.0.0-pre.20220909.2).

[Kernald]

That's great to know! I guess I might just wait a bit to update rules_jvm_external here.

[Bencodes]

The missing classpath issues are still logged to the console though

❯ bazel build //...
Starting local Bazel server and connecting to it...
INFO: Analyzed target //:bazel_desugar_issue_13553 (64 packages loaded, 1211 targets configured).
INFO: Found 1 target...
INFO: From Desugaring v1/https/repo1.maven.org/maven2/org/jetbrains/kotlinx/kotlinx-coroutines-core-jvm/1.6.4/kotlinx-coroutines-core-jvm-1.6.4.jar for Android:
Warning in external/maven/v1/https/repo1.maven.org/maven2/org/jetbrains/kotlinx/kotlinx-coroutines-core-jvm/1.6.4/kotlinx-coroutines-core-jvm-1.6.4.jar:kotlinx/coroutines/internal/ClassValueCtorCache$cache$1.class:
Type `java.lang.ClassValue` was not found, it is required for default or static interface methods desugaring of `kotlinx.coroutines.internal.ClassValueCtorCache$cache$1`
Warning in external/maven/v1/https/repo1.maven.org/maven2/org/jetbrains/kotlinx/kotlinx-coroutines-core-jvm/1.6.4/kotlinx-coroutines-core-jvm-1.6.4.jar:kotlinx/coroutines/debug/AgentPremain.class:
Type `sun.misc.SignalHandler` was not found, it is required for default or static interface methods desugaring of `kotlinx.coroutines.debug.AgentPremain$$InternalSyntheticLambda$2$7895cd395e43c061a299e224a1d3672f97bd4610fe97f0e188c9c199a1620b54$0`
Warning in external/maven/v1/https/repo1.maven.org/maven2/org/jetbrains/kotlinx/kotlinx-coroutines-core-jvm/1.6.4/kotlinx-coroutines-core-jvm-1.6.4.jar:kotlinx/coroutines/debug/AgentPremain$DebugProbesTransformer.class:
Type `java.lang.instrument.ClassFileTransformer` was not found, it is required for default or static interface methods desugaring of `kotlinx.coroutines.debug.AgentPremain$DebugProbesTransformer`Target //:bazel_desugar_issue_13553 up-to-date:
  bazel-bin/bazel_desugar_issue_13553_deploy.jar
  bazel-bin/bazel_desugar_issue_13553_unsigned.apk
  bazel-bin/bazel_desugar_issue_13553.apk
INFO: Elapsed time: 19.251s, Critical Path: 6.05s
INFO: 41 processes: 14 internal, 13 darwin-sandbox, 14 worker.
INFO: Build completed successfully, 41 total actions

[Bencodes]

If you want to work around this using the latest rules_jvm_external you can reference the downloaded artifacts by pinning the maven install, and referencing the files that get downloaded:

aar_import(
    name = "androidx_core_core",
    aar = "@androidx_core_core_1_8_0//file:file",
    srcjar = "@androidx_core_core_aar_sources_1_8_0//file:file",
    visibility = ["//visibility:public"],
    deps = [
        # Add missing dependencies here
    ],
)

[aptenodytes-forsteri]

We needed to do this to get it to work: https://gist.github.com/aptenodytes-forsteri/772d75cf41644166d8190e125e1ba367

• --patch-module to avoid error: package exists in another module: jdk.unsupported
• jvm_import instead of java_import
• Custom combined jar file to try to keep as identical to the downloaded jar file from maven as possible.