-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new strict_visibility_value= attribute to allow exposing strict dependencies to some scopes #649
Add new strict_visibility_value= attribute to allow exposing strict dependencies to some scopes #649
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's an amazing Bazel bug. Thanks for spotting this and creating this PR. Could you also please run ./scripts/generate_docs.sh
to make sure that the new flag is properly documented?
d07173d
to
73b2da0
Compare
Tests failed, will have a look |
a73c630
to
fbe093a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
funny, cla check thinks @shs96c hasn't signed it even being a codeowner |
…ependencies to some scopes Note that using package default_visibility doesn't always work so explicit visiblity attributes are needed bazelbuild/bazel#13681 Somewhat related to bazel-contrib#648 In combination this for example allows to create a class_name -> maven artifact resolver for transitive dependency classes while still keeping strict visibility (making transitive dependencies visible only to the resolve cli tool)
afb5416
to
fbbaee4
Compare
@dmivankov could you please remove my commit from the history? The CLA bot isn't happy since it came from the GitHub UI and doesn't have my proper email address. I'll merge the PR when it gives me the green light. |
fbbaee4
to
85e3bad
Compare
done, squashed and reathored commits related to toc |
Merged! Thank you @dmivankov! |
Also document strict_visibility_value from bazel-contrib#649
Also document strict_visibility_value from bazel-contrib#649
Also document strict_visibility_value from bazel-contrib#649
Because of another Bazel bug (bazelbuild/bazel#13553), accessing the jar files directly was quite useful - see Bencodes/bazel_issue_13553#1. This was possible because of the |
@Kernald jar files should still be accessible, do you have a more detailed repro case? |
Such a query doesn't seem to yield anything, but pinning seems to fix the visibility issue. Which seems to point to a slightly different behaviour between 4.3 and 4.4.2 without pinning, but similar behaviour with pinning (and pinning is a totally acceptable solution as far as I'm concerned, I should have done that from the start anyway). |
Note that using package default_visibility doesn't always work so explicit visiblity attributes are needed
bazelbuild/bazel#13681
Somewhat related to #648
In combination this for example allows to create a class_name -> maven artifact resolver for
transitive dependency classes while still keeping strict visibility (making transitive dependencies
visible only to the resolve cli tool)