[CmdBuffer] Draft experimental cmd buffer YAML #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace uses of `{buffer,src,dst}RowPitch` validation logic for the
`urMemBuffer{Read,Write,Copy}Rect` entry-points with a ternary
expression which checks the value, uses it when non-zero, and use
`region.width` otherwise. This matches the OpenCL documentation for
error conditions for the analogous entry-points. While the Coverity
defect only mentions modulo by zero, this patch also updates instances
where `{buffer,src,dst}RowPitch` is used in multiplication resulting in
a buggy comparison.
Wrapping every log message in a try-catch can be annoying. Reducing exceptions throws with a message to std::cerr in cases where messages have wrong syntax.
[logger/coverity] Replace logger exceptions with error messages
…ide-by-zero [ur] Fix modulo by zero Coverity defect
[UR] Add UI information
reble
changed the title
…on-properties [UR] Refactor urDevicePartition to use desc struct
EwanC
reviewed
May 31, 2023
…alidation Make GetInfo queries consistent and tested
…em_obj_arg [ur] Make hArgValue optional again in urKernelSetMemObj
Also add new kernel execution tests wherever relevant.
…onTests Add kernel execution tests.
This is a first draft of the contribution guide for experimental features. It does not attempt to address every eventuality but instead present a starting point which can be built upon with time and experience in enabling contributions.
…tures [ur] Add experimental feature contribution docs
…TestFixes A number of small fixes for the kernel and program CTS tests.
…-on-spec-generate [UR] Fail build on spec generate
[UR] Documents generator and conformance tests
…n-in-mako-write [UR] re-raise exception in makoWrite
Following on from oneapi-src#569 and oneapi-src#579 with the goal of failing the build when the generation scripts have errors, this patch introduces exceptions to the `_generate_valid_rst` where messages containing `error :` were being printed.
[ur] Link to contribution guide in readme
…-exceptions [ur] Actually fail when RST validation finds an error
Remove USMAllocContext and replace it with DisjointPool class with UMA-compatible interface. Move config parsing from USMAllocatorConfig ctor to a separate function and add tests for that parsing. Co-authored-by: Damian Duy <damian.duy@intel.com>
Pointer obtained from getSlab and getChunk can be aligned arbitrarly and might need to be adjusted by more than the difference between Size and AlignedSize.
Move USM allocator implementation from intel/llvm
- Adds support for command-buffers experimental feature - Add command-buffer desc type to common.yml - Add device info query for command-buffer support
- Add return codes to all cmdbuffer functions - Consistent naming for functions that append to a cmdbuffer
- Set command-buffer ordinal to 99 - Include license - Fix incorrect naming conventions - Make sync point parameters optional - Move and add explicit values to errors
Bensuo
force-pushed
the
ben/port-command-buffers
branch
from
e5f92ef
to
5897875
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial draft of YAML for experimental command buffer feature.
I've only included the YAML for now since I'm not sure what generated code needs to be committed yet.