-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][Bindless] Add experimental implementation of bindless images extension #9665
Conversation
…ges extension Co-authored-by: Isaac Ault <isaac.ault@codeplay.com> Co-authored-by: Hugh Bird <hugh.bird@codeplay.com> Co-authored-by: Duncan Brawley <duncan.brawley@codeplay.com> Co-authored-by: Przemek Malon <przemek.malon@codeplay.com> Co-authored-by: Chedy Najjar <chedy.najjar@codeplay.com> Co-authored-by: Sean Stirling <sean.stirling@codeplay.com> Co-authored-by: Peter Zuzek <peter@codeplay.com> Implement revision 3 of the bindless images extension proposal: https://github.com/intel/llvm/blob/8a48106617a9e2365c1935302d20e53bc7174368/sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images/sycl_ext_oneapi_bindless_images.asciidoc
@@ -126,6 +126,7 @@ _PI_API(piEnqueueMemUnmap) | |||
_PI_API(piextUSMHostAlloc) | |||
_PI_API(piextUSMDeviceAlloc) | |||
_PI_API(piextUSMSharedAlloc) | |||
_PI_API(piextUSMPitchedAlloc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed this internally with the team, but to make the point visible to all reviewers: As this PR changes PI then it will require Unified Runtime changes to match this.
Documentation on how to add experimental features is being written here oneapi-src/unified-runtime#546
You can ask us (@alycm, @jandres742, @kbenzie) any questions and we'll help you out.
You can also see in-progress work of another experimental change (not even a draft PR yet) here: Bensuo/unified-runtime#1. The YAML changes are where to look first, a lot of the rest is autogenerated from that.
Can this PR be closed now that we've moved to split PRs (#9808)? |
…s images extension (#9808) This PR stands as the first PR of four to make code review easier, covering the changes made to libclc. See the original whole [PR](#9665). This is the first part of the implementation of revision 3 of the [bindless images extension proposal](https://github.com/intel/llvm/blob/8a48106617a9e2365c1935302d20e53bc7174368/sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images/sycl_ext_oneapi_bindless_images.asciidoc). --------- Co-authored-by: SYCL Unbound Team <sycl.unbound@codeplay.com> Co-authored-by: Isaac Ault <isaac.ault@codeplay.com> Co-authored-by: Hugh Bird <hugh.bird@codeplay.com> Co-authored-by: Duncan Brawley <duncan.brawley@codeplay.com> Co-authored-by: Przemek Malon <przemek.malon@codeplay.com> Co-authored-by: Chedy Najjar <chedy.najjar@codeplay.com> Co-authored-by: Sean Stirling <sean.stirling@codeplay.com> Co-authored-by: Peter Zuzek <peter@codeplay.com>
Co-authored-by: Isaac Ault isaac.ault@codeplay.com
Co-authored-by: Hugh Bird hugh.bird@codeplay.com
Co-authored-by: Duncan Brawley duncan.brawley@codeplay.com
Co-authored-by: Przemek Malon przemek.malon@codeplay.com
Co-authored-by: Chedy Najjar chedy.najjar@codeplay.com
Co-authored-by: Sean Stirling sean.stirling@codeplay.com
Co-authored-by: Peter Zuzek peter@codeplay.com
Implement revision 3 of the bindless images extension proposal: https://github.com/intel/llvm/blob/8a48106617a9e2365c1935302d20e53bc7174368/sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images/sycl_ext_oneapi_bindless_images.asciidoc