Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(packages/jellyfish-api-core): fix descendants test flakiness with a deterministic setup #1997

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

fuxingloh
Copy link
Contributor

@fuxingloh fuxingloh commented Jan 24, 2023

What this PR does / why we need it:

Use a deterministic setup for getMempoolDescendants to prevent test flakiness.

Fixes part of #1771

@github-actions github-actions bot added area/packages kind/chore Non feature change labels Jan 24, 2023
@codeclimate
Copy link

codeclimate bot commented Jan 24, 2023

Code Climate has analyzed commit 39415ab and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Jan 24, 2023

Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit 39415ab
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/63cf862341b18700089790d6
😎 Deploy Preview https://deploy-preview-1997--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Base: 89.43% // Head: 93.60% // Increases project coverage by +4.17% 🎉

Coverage data is based on head (39415ab) compared to base (e5b6f74).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1997      +/-   ##
==========================================
+ Coverage   89.43%   93.60%   +4.17%     
==========================================
  Files         365      366       +1     
  Lines       10977    10979       +2     
  Branches     1431     1431              
==========================================
+ Hits         9817    10277     +460     
+ Misses       1108      676     -432     
+ Partials       52       26      -26     
Impacted Files Coverage Δ
...ners/src/containers/RegTestContainer/Persistent.ts 11.11% <0.00%> (-81.49%) ⬇️
packages/whale-api-client/src/api/governance.ts 48.38% <0.00%> (-45.17%) ⬇️
packages/whale-api-client/src/api/address.ts 77.77% <0.00%> (-22.23%) ⬇️
.../whale-api/src/module.api/governance.controller.ts 88.23% <0.00%> (-5.89%) ⬇️
...le-api/src/module.api/pipes/api.validation.pipe.ts 85.71% <0.00%> (-3.58%) ⬇️
apps/whale-api/src/module.api/_core/api.error.ts 60.00% <0.00%> (-2.86%) ⬇️
packages/whale-api-client/src/whale.api.client.ts 93.18% <0.00%> (-2.28%) ⬇️
packages/jellyfish-api-core/src/category/wallet.ts 95.50% <0.00%> (-2.25%) ⬇️
packages/jellyfish-block/src/index.ts 100.00% <0.00%> (ø)
apps/whale-api/src/module.api/poolpair.service.ts 81.64% <0.00%> (+0.39%) ⬆️
... and 59 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

Docker build preview for jellyfish/apps is ready!

Built with commit 5ed073d

  • ghcr.io/jellyfishsdk/legacy-api:pr-1997
  • ghcr.io/jellyfishsdk/playground-api:pr-1997
  • ghcr.io/jellyfishsdk/status-api:pr-1997
  • ghcr.io/jellyfishsdk/whale-api:pr-1997

You can also get an immutable image with the commit hash

  • ghcr.io/jellyfishsdk/legacy-api:5ed073d8e9afce8ff75a3f839a7b7bd5f9b69a4d
  • ghcr.io/jellyfishsdk/playground-api:5ed073d8e9afce8ff75a3f839a7b7bd5f9b69a4d
  • ghcr.io/jellyfishsdk/status-api:5ed073d8e9afce8ff75a3f839a7b7bd5f9b69a4d
  • ghcr.io/jellyfishsdk/whale-api:5ed073d8e9afce8ff75a3f839a7b7bd5f9b69a4d

@fuxingloh fuxingloh changed the title chore(jellyfish-api-core): reduce mempool descendants test flakiness with a deterministic setup chore(jellyfish-api-core): fix descendants test flakiness with a deterministic setup Jan 24, 2023
@fuxingloh fuxingloh changed the title chore(jellyfish-api-core): fix descendants test flakiness with a deterministic setup chore(packages/jellyfish-api-core): fix descendants test flakiness with a deterministic setup Jan 24, 2023
@fuxingloh fuxingloh marked this pull request as ready for review January 24, 2023 07:50
@fuxingloh fuxingloh merged commit a8a60da into main Jan 25, 2023
@fuxingloh fuxingloh deleted the fuxingloh/flaky-get-mempool-descendants branch January 25, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/packages kind/chore Non feature change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants