-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document and Resolve all Flaky Tests #1771
Labels
Comments
jellyfishsdk-bot
added
triage/accepted
Triage has been accepted
area/apps
area/packages
labels
Sep 22, 2022
This was referenced Jan 24, 2023
Merged
Merged
fuxingloh
added a commit
that referenced
this issue
Jan 25, 2023
… by using `waitForExpect` (#1999) #### What this PR does / why we need it: Add `waitForExpect` for `wallet.listUnspent` within `WalletController.test.ts` as it's known to be "flaky" from testing; wallet operations run differently on a separate wallet subsystem from blockchain core `connectBlock`, a block might get connected first before your wallet entries get indexed. #### Which issue(s) does this PR fixes?: Fixes part of #1771
fuxingloh
added a commit
that referenced
this issue
Jan 31, 2023
…syTime` condition to reduce test flakiness (#1998) #### What this PR does / why we need it: I would forgo this test completely (if this is still causing flakiness) since we can't control (or should not) the CI environment. Tests concurrency within the pipeline (Jest concurrent and Docker spinup) skew "hardTime" and "easyTime" making the test number very unreliable. We could isolate the tests but frankly too much trouble to prove an otherwise proven theory. #### Which issue(s) does this PR fixes?: Fixes part of #1771
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
What would you like to be added:
As per the title, documenting and resolving all flaky test cases.
/area packages apps
/triage accepted
Flaky Tests:
The text was updated successfully, but these errors were encountered: