Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(packages/jellyfish-wallet-encrypted): use simple hardTime > easyTime condition to reduce test flakiness #1998

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

fuxingloh
Copy link
Contributor

@fuxingloh fuxingloh commented Jan 24, 2023

What this PR does / why we need it:

I would forgo this test completely (if this is still causing flakiness) since we can't control (or should not) the CI environment. Tests concurrency within the pipeline (Jest concurrent and Docker spinup) skew "hardTime" and "easyTime" making the test number very unreliable.

We could isolate the tests but frankly too much trouble to prove an otherwise proven theory.

Which issue(s) does this PR fixes?:

Fixes part of #1771

@github-actions github-actions bot added area/packages kind/chore Non feature change labels Jan 24, 2023
@netlify
Copy link

netlify bot commented Jan 24, 2023

Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit 3dbf1e3
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/63cf8db4b40564000999737b
😎 Deploy Preview https://deploy-preview-1998--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Jan 24, 2023

Code Climate has analyzed commit 3dbf1e3 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Base: 89.43% // Head: 93.35% // Increases project coverage by +3.92% 🎉

Coverage data is based on head (3dbf1e3) compared to base (e5b6f74).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1998      +/-   ##
==========================================
+ Coverage   89.43%   93.35%   +3.92%     
==========================================
  Files         365      366       +1     
  Lines       10977    10985       +8     
  Branches     1431     1432       +1     
==========================================
+ Hits         9817    10255     +438     
+ Misses       1108      701     -407     
+ Partials       52       29      -23     
Impacted Files Coverage Δ
apps/libs/blockchaincpp/src/BlockchainCppModule.ts 50.00% <0.00%> (-38.24%) ⬇️
...ule.indexer/model/dftx/set.oracle.data.interval.ts 61.40% <0.00%> (-35.09%) ⬇️
...pi/src/module.indexer/model/dftx/appoint.oracle.ts 75.75% <0.00%> (-24.25%) ⬇️
...api/src/module.indexer/model/dftx/update.oracle.ts 74.41% <0.00%> (-23.26%) ⬇️
packages/jellyfish-crypto/src/bech32.ts 79.16% <0.00%> (-20.84%) ⬇️
...api/src/module.indexer/model/dftx/remove.oracle.ts 76.66% <0.00%> (-20.00%) ⬇️
apps/whale-api/src/module.model/oracle.history.ts 84.61% <0.00%> (-15.39%) ⬇️
...ps/whale-api/src/module.model/oracle.price.feed.ts 84.61% <0.00%> (-15.39%) ⬇️
...i/src/module.indexer/model/dftx/set.oracle.data.ts 82.75% <0.00%> (-13.80%) ⬇️
...le-api/src/module.model/oracle.price.aggregated.ts 86.66% <0.00%> (-13.34%) ⬇️
... and 73 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fuxingloh fuxingloh changed the title chore(packages/jellyfish-wallet-encrypted): half test delta of hardTime and easyTime to reduce test flakiness chore(packages/jellyfish-wallet-encrypted): use simple hardTime > easyTime condition to reduce test flakiness Jan 24, 2023
@github-actions
Copy link

Docker build preview for jellyfish/apps is ready!

Built with commit d3efae0

  • ghcr.io/jellyfishsdk/legacy-api:pr-1998
  • ghcr.io/jellyfishsdk/playground-api:pr-1998
  • ghcr.io/jellyfishsdk/status-api:pr-1998
  • ghcr.io/jellyfishsdk/whale-api:pr-1998

You can also get an immutable image with the commit hash

  • ghcr.io/jellyfishsdk/legacy-api:d3efae0f87aca716643bdb5d21fcc9a254f982cd
  • ghcr.io/jellyfishsdk/playground-api:d3efae0f87aca716643bdb5d21fcc9a254f982cd
  • ghcr.io/jellyfishsdk/status-api:d3efae0f87aca716643bdb5d21fcc9a254f982cd
  • ghcr.io/jellyfishsdk/whale-api:d3efae0f87aca716643bdb5d21fcc9a254f982cd

@fuxingloh fuxingloh marked this pull request as ready for review January 24, 2023 08:36
@fuxingloh fuxingloh merged commit eefd5dd into main Jan 31, 2023
@fuxingloh fuxingloh deleted the fuxingloh/sycrypt-falkiness branch January 31, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/packages kind/chore Non feature change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant