Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(apps/playground-api): fix flakiness in WalletController.test.ts by using waitForExpect #1999

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

fuxingloh
Copy link
Contributor

What this PR does / why we need it:

Add waitForExpect for wallet.listUnspent within WalletController.test.ts as it's known to be "flaky" from testing; wallet operations run differently on a separate wallet subsystem from blockchain core connectBlock, a block might get connected first before your wallet entries get indexed.

Which issue(s) does this PR fixes?:

Fixes part of #1771

@codeclimate
Copy link

codeclimate bot commented Jan 24, 2023

Code Climate has analyzed commit 31e6d41 and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Jan 24, 2023

Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit 31e6d41
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/63cf902843d55a000c7130a2
😎 Deploy Preview https://deploy-preview-1999--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Base: 92.19% // Head: 93.93% // Increases project coverage by +1.73% 🎉

Coverage data is based on head (31e6d41) compared to base (19011fd).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1999      +/-   ##
==========================================
+ Coverage   92.19%   93.93%   +1.73%     
==========================================
  Files         366      366              
  Lines       10985    10985              
  Branches     1432     1432              
==========================================
+ Hits        10128    10319     +191     
+ Misses        818      641     -177     
+ Partials       39       25      -14     
Impacted Files Coverage Δ
...nsaction-builder/src/txn/txn_builder_masternode.ts 33.33% <0.00%> (-66.67%) ⬇️
...h-transaction-builder/src/txn/txn_builder_loans.ts 88.57% <0.00%> (-11.43%) ⬇️
packages/jellyfish-api-core/src/category/oracle.ts 91.42% <0.00%> (-8.58%) ⬇️
packages/jellyfish-transaction/src/tx_composer.ts 78.33% <0.00%> (-1.67%) ⬇️
packages/jellyfish-api-core/src/category/vault.ts 94.73% <0.00%> (ø)
...s/legacy-api/src/controllers/PoolPairController.ts 86.36% <0.00%> (+1.13%) ⬆️
...-api/src/module.indexer/model/dftx/active.price.ts 83.56% <0.00%> (+1.36%) ⬆️
packages/jellyfish-address/src/script/index.ts 100.00% <0.00%> (+2.04%) ⬆️
...nsaction-builder/src/txn/txn_builder_governance.ts 79.31% <0.00%> (+3.44%) ⬆️
packages/jellyfish-transaction/src/script/data.ts 81.63% <0.00%> (+6.12%) ⬆️
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

Docker build preview for jellyfish/apps is ready!

Built with commit 1244dae

  • ghcr.io/jellyfishsdk/legacy-api:pr-1999
  • ghcr.io/jellyfishsdk/playground-api:pr-1999
  • ghcr.io/jellyfishsdk/status-api:pr-1999
  • ghcr.io/jellyfishsdk/whale-api:pr-1999

You can also get an immutable image with the commit hash

  • ghcr.io/jellyfishsdk/legacy-api:1244daed7335a0da7daabe23efaa74c7c5080975
  • ghcr.io/jellyfishsdk/playground-api:1244daed7335a0da7daabe23efaa74c7c5080975
  • ghcr.io/jellyfishsdk/status-api:1244daed7335a0da7daabe23efaa74c7c5080975
  • ghcr.io/jellyfishsdk/whale-api:1244daed7335a0da7daabe23efaa74c7c5080975

@fuxingloh fuxingloh marked this pull request as ready for review January 24, 2023 09:46
@fuxingloh fuxingloh merged commit 23b5c04 into main Jan 25, 2023
@fuxingloh fuxingloh deleted the fuxingloh/wallet-controller.wait-for-expect branch January 25, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant