Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed dep.protobuf.version to dep.protobuf-bom.version #2

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Changed dep.protobuf.version to dep.protobuf-bom.version #2

merged 1 commit into from
Aug 11, 2022

Conversation

jayhomn-bitquill
Copy link

The dep.protobuf.version variable was used in this fork https://github.com/rafael-telles/arrow/tree/flight-jdbc-driver where it was referencing variables in the parent pom that does not exist in the official arrow fork of flight-sql-jdbc which this branch is based off of. This caused a build issue where dep.protobuf.version is not defined. Changing it to dep.protobuf-bom.version fixes the build issue

@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@jayhomn-bitquill jayhomn-bitquill merged commit ccf812f into BQ-flight-jdbc-driver Aug 11, 2022
jduo pushed a commit that referenced this pull request Sep 12, 2022
@vfraga
Fix Flight SQL -> Flight JDBC rebase mismatch #2
856b597
alinaliBQ pushed a commit that referenced this pull request Nov 21, 2023
@RoyZhang2022
Fix wrong linux package name and remove unneeded files (#2)
12de634 
* code uploading

* fix cppcheck failure (#1)

* fix cppcheck failure

* fix build script not running and credentials could not be fetched

* restore configure-aws-credentials to v2

* add execute permission for shell scripts

* remove bash for mac build scripts

* trigger all tests

* verify signer works fine

* fix singer could not find the installer package

* change signed installer name

* fix linux package wrong name issue

* restore signer flag

* add .gitignore

* remove unneeded files

* remove unneeded files

* address comments

* add version to installer name

* remove not needed file
alinaliBQ pushed a commit that referenced this pull request Nov 23, 2023
@RoyZhang2022 @alinaliBQ
Fix wrong linux package name and remove unneeded files (#2)
75fd00f 
* code uploading

* fix cppcheck failure (#1)

* fix cppcheck failure

* fix build script not running and credentials could not be fetched

* restore configure-aws-credentials to v2

* add execute permission for shell scripts

* remove bash for mac build scripts

* trigger all tests

* verify signer works fine

* fix singer could not find the installer package

* change signed installer name

* fix linux package wrong name issue

* restore signer flag

* add .gitignore

* remove unneeded files

* remove unneeded files

* address comments

* add version to installer name

* remove not needed file
alinaliBQ pushed a commit that referenced this pull request Nov 28, 2023
@RoyZhang2022 @alinaliBQ
Fix wrong linux package name and remove unneeded files (#2)
621cffe 
* code uploading

* fix cppcheck failure (#1)

* fix cppcheck failure

* fix build script not running and credentials could not be fetched

* restore configure-aws-credentials to v2

* add execute permission for shell scripts

* remove bash for mac build scripts

* trigger all tests

* verify signer works fine

* fix singer could not find the installer package

* change signed installer name

* fix linux package wrong name issue

* restore signer flag

* add .gitignore

* remove unneeded files

* remove unneeded files

* address comments

* add version to installer name

* remove not needed file
alinaliBQ pushed a commit that referenced this pull request Nov 28, 2023
@RoyZhang2022 @alinaliBQ
Fix wrong linux package name and remove unneeded files (#2)
e45d7cf 
* code uploading

* fix cppcheck failure (#1)

* fix cppcheck failure

* fix build script not running and credentials could not be fetched

* restore configure-aws-credentials to v2

* add execute permission for shell scripts

* remove bash for mac build scripts

* trigger all tests

* verify signer works fine

* fix singer could not find the installer package

* change signed installer name

* fix linux package wrong name issue

* restore signer flag

* add .gitignore

* remove unneeded files

* remove unneeded files

* address comments

* add version to installer name

* remove not needed file
alinaliBQ pushed a commit that referenced this pull request Dec 1, 2023
@RoyZhang2022 @alinaliBQ
Fix wrong linux package name and remove unneeded files (#2)
c3e1a7a 
* code uploading

* fix cppcheck failure (#1)

* fix cppcheck failure

* fix build script not running and credentials could not be fetched

* restore configure-aws-credentials to v2

* add execute permission for shell scripts

* remove bash for mac build scripts

* trigger all tests

* verify signer works fine

* fix singer could not find the installer package

* change signed installer name

* fix linux package wrong name issue

* restore signer flag

* add .gitignore

* remove unneeded files

* remove unneeded files

* address comments

* add version to installer name

* remove not needed file
alinaliBQ pushed a commit that referenced this pull request Dec 5, 2023
@RoyZhang2022 @alinaliBQ
Fix wrong linux package name and remove unneeded files (#2)
a975b47 
* code uploading

* fix cppcheck failure (#1)

* fix cppcheck failure

* fix build script not running and credentials could not be fetched

* restore configure-aws-credentials to v2

* add execute permission for shell scripts

* remove bash for mac build scripts

* trigger all tests

* verify signer works fine

* fix singer could not find the installer package

* change signed installer name

* fix linux package wrong name issue

* restore signer flag

* add .gitignore

* remove unneeded files

* remove unneeded files

* address comments

* add version to installer name

* remove not needed file
alinaliBQ pushed a commit that referenced this pull request Dec 7, 2023
@RoyZhang2022 @alinaliBQ
Fix wrong linux package name and remove unneeded files (#2)
91e2a1b 
* code uploading

* fix cppcheck failure (#1)

* fix cppcheck failure

* fix build script not running and credentials could not be fetched

* restore configure-aws-credentials to v2

* add execute permission for shell scripts

* remove bash for mac build scripts

* trigger all tests

* verify signer works fine

* fix singer could not find the installer package

* change signed installer name

* fix linux package wrong name issue

* restore signer flag

* add .gitignore

* remove unneeded files

* remove unneeded files

* address comments

* add version to installer name

* remove not needed file
@alinaliBQ alinaliBQ deleted the flight-jdbc-driver-pom-not-building branch December 7, 2023 23:52
alinaliBQ pushed a commit that referenced this pull request Dec 13, 2023
@RoyZhang2022 @alinaliBQ
Fix wrong linux package name and remove unneeded files (#2)
d4e3300 
* code uploading

* fix cppcheck failure (#1)

* fix cppcheck failure

* fix build script not running and credentials could not be fetched

* restore configure-aws-credentials to v2

* add execute permission for shell scripts

* remove bash for mac build scripts

* trigger all tests

* verify signer works fine

* fix singer could not find the installer package

* change signed installer name

* fix linux package wrong name issue

* restore signer flag

* add .gitignore

* remove unneeded files

* remove unneeded files

* address comments

* add version to installer name

* remove not needed file
alinaliBQ pushed a commit that referenced this pull request Dec 18, 2023
@RoyZhang2022 @alinaliBQ
Fix wrong linux package name and remove unneeded files (#2)
fad7d79 
* code uploading

* fix cppcheck failure (#1)

* fix cppcheck failure

* fix build script not running and credentials could not be fetched

* restore configure-aws-credentials to v2

* add execute permission for shell scripts

* remove bash for mac build scripts

* trigger all tests

* verify signer works fine

* fix singer could not find the installer package

* change signed installer name

* fix linux package wrong name issue

* restore signer flag

* add .gitignore

* remove unneeded files

* remove unneeded files

* address comments

* add version to installer name

* remove not needed file
alinaliBQ pushed a commit that referenced this pull request Dec 18, 2023
@RoyZhang2022 @alinaliBQ
Fix wrong linux package name and remove unneeded files (#2)
d8cce10 
* code uploading

* fix cppcheck failure (#1)

* fix cppcheck failure

* fix build script not running and credentials could not be fetched

* restore configure-aws-credentials to v2

* add execute permission for shell scripts

* remove bash for mac build scripts

* trigger all tests

* verify signer works fine

* fix singer could not find the installer package

* change signed installer name

* fix linux package wrong name issue

* restore signer flag

* add .gitignore

* remove unneeded files

* remove unneeded files

* address comments

* add version to installer name

* remove not needed file
alinaliBQ pushed a commit that referenced this pull request Dec 20, 2023
@amazon-auto @alinaliBQ
Fix floating intergration test issue, document update and github auto…
e7b70d7 
…mation improvement (#4)

* fix occasional test failure

* document update

* add check for credentials leak

Fix wrong linux package name and remove unneeded files (#2)

* code uploading

* fix cppcheck failure (#1)

* fix cppcheck failure

* fix build script not running and credentials could not be fetched

* restore configure-aws-credentials to v2

* add execute permission for shell scripts

* remove bash for mac build scripts

* trigger all tests

* verify signer works fine

* fix singer could not find the installer package

* change signed installer name

* fix linux package wrong name issue

* restore signer flag

* add .gitignore

* remove unneeded files

* remove unneeded files

* address comments

* add version to installer name

* remove not needed file

fix cppcheck failure (#1)

* fix cppcheck failure

* fix build script not running and credentials could not be fetched

* restore configure-aws-credentials to v2

* add execute permission for shell scripts

* remove bash for mac build scripts

* trigger all tests

code uploading

Initial commit

fix bracket missing (#5)

Pass driver info to Timestream using user agent (#6)

* pass driver info to Timestream using user agent

* add log for user agent setting

Fixing awslabs links. (#8)

Signed-off-by: forestmvey <forestv@bitquilltech.com>

Move AWS TS ODBC Driver under flight sql subdirectory

Enable Windows builds, workflow files are based on Amazon Timestream ODBC driver seed

disable integration tests from running. The win-build.yml file is copied from Amazon Timestream ODBC driver code.

Fix CMAKE code formats

Note that rest of lint errors are not solved yet.

Fix python code doc errors

Enable linux build, the file is copied from Amazon Timestream ODBC seed

* integration tests are disabled.
* allow build scripts to be run through `chmod`.

Enable macOS builds, workflow files are copied from Amazon TS ODBC seed

Move Timestream ODBC driver seed under cpp/src/flightsql_odbc

* Updated workflows to accommodate this change.

Remove Timestream-related code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lang-java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayhomn-bitquill @jhmannok