Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for downloading flights from alternate endpoints #4

Closed

Conversation

avantgardnerio
Copy link

  • Add support for downloading flights from alternate EPs
    • arrow-ballista uses multiple executors to run a query in parallel, and this PR allows them each to serve their result
  • Fix NPE when there are no extraParams
  • Exclude more packages from Maven shade so developers can attach a debugger when integration testing shaded jar
    • e.g. when testing from one's favorite SQL IDE (DataGrip, SQLCommander, etc)
  • Fix dep.protobuf.version build error
  • Bump to v9 to match main repo

@jduo @jayhomn-bitquill @andygrove

See rafael-telles#42 for more detail.

Filing in response to apache#13900 (comment)

@lidavidm is this the correct place to PR to?

Brent Gardner added 4 commits August 17, 2022 14:38
Try to publish

Attach workspace

Don't rebuild every time

Only need to deploy jdbc-driver

Only need to deploy jdbc-driver

Might work this time?

Keep trying

Try to tag

Add docker

Build from correct directory

typo
@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@lidavidm
Copy link

Hmm, I'm hoping we can get in the 'base' PR, then review these additions (which are very much welcomed). Also because I think we're supposed to keep discussion on Apache-maintained sites

@lidavidm
Copy link

Mostly because the base PR is so large, it's hard to keep it and all the changes in mind

@avantgardnerio
Copy link
Author

Will re-open as a PR against the apache/arrow repo.

alinaliBQ pushed a commit that referenced this pull request Nov 21, 2023
…mation improvement (#4)

* fix occasional test failure

* document update

* add check for credentials leak
alinaliBQ pushed a commit that referenced this pull request Nov 23, 2023
…mation improvement (#4)

* fix occasional test failure

* document update

* add check for credentials leak
alinaliBQ pushed a commit that referenced this pull request Nov 28, 2023
…mation improvement (#4)

* fix occasional test failure

* document update

* add check for credentials leak
alinaliBQ pushed a commit that referenced this pull request Nov 28, 2023
…mation improvement (#4)

* fix occasional test failure

* document update

* add check for credentials leak
alinaliBQ pushed a commit that referenced this pull request Dec 1, 2023
…mation improvement (#4)

* fix occasional test failure

* document update

* add check for credentials leak
alinaliBQ pushed a commit that referenced this pull request Dec 5, 2023
…mation improvement (#4)

* fix occasional test failure

* document update

* add check for credentials leak
alinaliBQ pushed a commit that referenced this pull request Dec 7, 2023
…mation improvement (#4)

* fix occasional test failure

* document update

* add check for credentials leak
alinaliBQ pushed a commit that referenced this pull request Dec 13, 2023
…mation improvement (#4)

* fix occasional test failure

* document update

* add check for credentials leak
alinaliBQ pushed a commit that referenced this pull request Dec 18, 2023
…mation improvement (#4)

* fix occasional test failure

* document update

* add check for credentials leak
alinaliBQ pushed a commit that referenced this pull request Dec 18, 2023
…mation improvement (#4)

* fix occasional test failure

* document update

* add check for credentials leak
alinaliBQ pushed a commit that referenced this pull request Dec 20, 2023
…mation improvement (#4)

* fix occasional test failure

* document update

* add check for credentials leak

Fix wrong linux package name and remove unneeded files (#2)

* code uploading

* fix cppcheck failure (#1)

* fix cppcheck failure

* fix build script not running and credentials could not be fetched

* restore configure-aws-credentials to v2

* add execute permission for shell scripts

* remove bash for mac build scripts

* trigger all tests

* verify signer works fine

* fix singer could not find the installer package

* change signed installer name

* fix linux package wrong name issue

* restore signer flag

* add .gitignore

* remove unneeded files

* remove unneeded files

* address comments

* add version to installer name

* remove not needed file

fix cppcheck failure (#1)

* fix cppcheck failure

* fix build script not running and credentials could not be fetched

* restore configure-aws-credentials to v2

* add execute permission for shell scripts

* remove bash for mac build scripts

* trigger all tests

code uploading

Initial commit

fix bracket missing (#5)

Pass driver info to Timestream using user agent (#6)

* pass driver info to Timestream using user agent

* add log for user agent setting

Fixing awslabs links. (#8)

Signed-off-by: forestmvey <forestv@bitquilltech.com>

Move AWS TS ODBC Driver under flight sql subdirectory

Enable Windows builds, workflow files are based on Amazon Timestream ODBC driver seed

disable integration tests from running. The win-build.yml file is copied from Amazon Timestream ODBC driver code.

Fix CMAKE code formats

Note that rest of lint errors are not solved yet.

Fix python code doc errors

Enable linux build, the file is copied from Amazon Timestream ODBC seed

* integration tests are disabled.
* allow build scripts to be run through `chmod`.

Enable macOS builds, workflow files are copied from Amazon TS ODBC seed

Move Timestream ODBC driver seed under cpp/src/flightsql_odbc

* Updated workflows to accommodate this change.

Remove Timestream-related code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants