Fixing string format change #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale
requested review from
MaxKsyunz,
Yury-Fridlyand,
forestmvey,
acarbonetto and
GumpacG
as code owners
Codecov Report
@@ Coverage Diff @@
## integ/StringFormat_fix #334 +/- ##
=========================================================
Coverage 97.42% 97.42%
Complexity 4647 4647
=========================================================
Files 408 408
Lines 11526 11526
Branches 839 839
=========================================================
Hits 11229 11229
Misses 290 290
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Comment on lines
301
to
304
| private String query(String sql) { | ||
| return explain(sql); | ||
| } | ||
|
|
matthewryanwells
approved these changes
Aug 8, 2023
Yury-Fridlyand
approved these changes
Aug 8, 2023
Comment on lines
301
to
304
| private String query(String sql) { | ||
| return explain(sql); | ||
| } | ||
|
|
GumpacG
approved these changes
Aug 8, 2023
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale
added a commit
that referenced
this pull request
Aug 8, 2023
* Fixing strings change from main OS repo. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Fixing issues. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Fixing changed syntax to toStirng. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Fixing changed syntax to toStirng. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * add tosttring fix to RestSQLQueryActionCursorFallbackTest Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * added unused function Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
matthewryanwells
pushed a commit
that referenced
this pull request
Aug 9, 2023
* Fixing strings change from main OS repo. * Fixing issues. * Fixing changed syntax to toStirng. * Fixing changed syntax to toStirng. * add tosttring fix to RestSQLQueryActionCursorFallbackTest * added unused function --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale
added a commit
that referenced
this pull request
Aug 9, 2023
* Fixing strings change from main OS repo. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Fixing issues. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Fixing changed syntax to toStirng. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Fixing changed syntax to toStirng. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * add tosttring fix to RestSQLQueryActionCursorFallbackTest Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * added unused function Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Yury-Fridlyand
pushed a commit
that referenced
this pull request
Aug 11, 2023
* Fixing strings change from main OS repo. * Fixing issues. * Fixing changed syntax to toStirng. * Fixing changed syntax to toStirng. * add tosttring fix to RestSQLQueryActionCursorFallbackTest * added unused function --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale
added a commit
that referenced
this pull request
Aug 14, 2023
* Fixing strings change from main OS repo. * Fixing issues. * Fixing changed syntax to toStirng. * Fixing changed syntax to toStirng. * add tosttring fix to RestSQLQueryActionCursorFallbackTest * added unused function --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix changes in regards to this PR opensearch-project/OpenSearch#9127 with breaking changes.
Changes imports to include new path inside core. Update calls to toString.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.