[Manual Backport #1943] Fixing string format change #1943 #1946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixing strings change from main OS repo. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Fixing issues. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Fixing changed syntax to toStirng. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Fixing changed syntax to toStirng. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * add tosttring fix to RestSQLQueryActionCursorFallbackTest Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * added unused function Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
acarbonetto
approved these changes
Aug 9, 2023
GumpacG
approved these changes
Aug 9, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #1946 +/- ##
=========================================
Coverage 97.42% 97.42%
Complexity 4648 4648
=========================================
Files 408 408
Lines 11528 11528
Branches 839 839
=========================================
Hits 11231 11231
Misses 290 290
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. |
Yury-Fridlyand
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix changes in regards to this PR opensearch-project/OpenSearch#9127 with breaking changes.
Changes imports to include new path inside core. Update calls to toString.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.