Java: Add the XGROUP CREATE and XGROUP DESTROY commands
#359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
java/client/src/main/java/glide/api/commands/StreamBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/StreamBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/StreamBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/StreamBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/StreamBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/stream/StreamGroupOptions.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/stream/StreamGroupOptions.java
Show resolved
Hide resolved
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Yury-Fridlyand
approved these changes
Jun 12, 2024
java/client/src/main/java/glide/api/models/commands/stream/StreamGroupOptions.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Yury-Fridlyand
approved these changes
Jun 12, 2024
acarbonetto
merged commit f17bc6c
into
java/integ_acarbo_add_xgroup_create_destroy
44 checks passed
acarbonetto
added a commit
that referenced
this pull request
Jun 17, 2024
…o#1557) * Java: Add the `XGROUP CREATE` and `XGROUP DESTROY` commands (#359) * JAVA: Add the XGROUP CREATE and DESTROY command Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Fix XGROUP DESTROY Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Clean up for self-review Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * cargo fmt Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Change builder to use constructors Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Add optional javadocs Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Update options to use builder Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * SPOTLESS Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Update doc Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
cyip10
pushed a commit
that referenced
this pull request
Jun 19, 2024
…o#1557) * Java: Add the `XGROUP CREATE` and `XGROUP DESTROY` commands (#359) * JAVA: Add the XGROUP CREATE and DESTROY command Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Fix XGROUP DESTROY Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Clean up for self-review Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * cargo fmt Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Change builder to use constructors Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Add optional javadocs Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Update options to use builder Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * SPOTLESS Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Update doc Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
cyip10
pushed a commit
that referenced
this pull request
Jun 24, 2024
…o#1557) * Java: Add the `XGROUP CREATE` and `XGROUP DESTROY` commands (#359) * JAVA: Add the XGROUP CREATE and DESTROY command Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Fix XGROUP DESTROY Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Clean up for self-review Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * cargo fmt Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Change builder to use constructors Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Add optional javadocs Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Update options to use builder Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * SPOTLESS Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Update doc Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://valkey.io/commands/xgroup-create/
https://valkey.io/commands/xgroup-destroy/